The reason this patch still fails is that the patch process runs
findbugs before applying the patch and then again after applying the
patch so that a diff can be determined. Running findbugs before the
patch is applied is broken since we need this patch to fix findbugs.
I'll commit this patch.
I've also updated the patch script so that a failure of findbugs like
that caused by HADOOP-2207 will cause a -1 comment.
Cheers,
Nige
On Nov 25, 2007, at 4:26 PM, stack wrote:
Nigel:
Any idea whats up w/ these findbugs failures?
Thanks,
St.Ack
From: "stack (JIRA)" <[EMAIL PROTECTED]>
Date: November 25, 2007 4:20:43 PM PST
To: hadoop-dev@lucene.apache.org
Subject: [jira] Commented: (HADOOP-2272) findbugs currently fails
due to hadoop-streaming having moved
Reply-To: hadoop-dev@lucene.apache.org
[ https://issues.apache.org/jira/browse/HADOOP-2272?
page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
tabpanel#action_12545311 ]
stack commented on HADOOP-2272:
-------------------------------
Same thing just now w/ complaint about FilesNotFound.
Looking on disk up on hudson, I see a currentFindbugsWarnings.xml
at /export/home/hudson/patch/current is empty. That could cause
the first exception I suppose going by the findbugs code: http://
fisheye2.cenqua.com/rdiff/findbugs?csid=1342&u&N.
There is no findbugsMerge.xml file nor a
newPatchFindbugsWarnings.xml (There is a patchFindbugsWarnings.xml
over under current). The trunk/build/test/findbugs has only hadoop-
findbugs-report.xml and hadoop-findbugs-report.html -- the product
of the findbugs run.
Asking Mr. Daley....
findbugs currently fails due to hadoop-streaming having moved
-------------------------------------------------------------
Key: HADOOP-2272
URL: https://issues.apache.org/jira/browse/
HADOOP-2272
Project: Hadoop
Issue Type: Bug
Components: build
Affects Versions: 0.15.0
Reporter: Adrian Woodhead
Assignee: stack
Attachments: HADOOP-2272-1.patch
If you do a fresh checkout of the trunk and try run findbugs you
get the following error:
findbugs:
[findbugs] Running FindBugs...
[findbugs] Exception in thread "main" java.util.zip.ZipException:
Error opening /tmp/x/trunk/build/hadoop-0.16.0-dev-streaming.jar
[findbugs] at
edu.umd.cs.findbugs.classfile.impl.ZipFileCodeBase.<init>
(ZipFileCodeBase.java:61)
[findbugs] at
edu.umd.cs.findbugs.classfile.impl.ClassFactory.createFilesystemCodeB
ase(ClassFactory.java:96)
[findbugs] at
edu.umd.cs.findbugs.classfile.impl.FilesystemCodeBaseLocator.openCode
Base(FilesystemCodeBaseLocator.java:63)
[findbugs] at
edu.umd.cs.findbugs.classfile.impl.ClassPathBuilder.processWorkList
(ClassPathBuilder.java:381)
[findbugs] at
edu.umd.cs.findbugs.classfile.impl.ClassPathBuilder.build
(ClassPathBuilder.java:192)
[findbugs] at edu.umd.cs.findbugs.FindBugs2.buildClassPath
(FindBugs2.java:432)
[findbugs] at edu.umd.cs.findbugs.FindBugs2.execute
(FindBugs2.java:160)
[findbugs] at edu.umd.cs.findbugs.FindBugs.runMain
(FindBugs.java:1521)
[findbugs] at edu.umd.cs.findbugs.FindBugs2.main
(FindBugs2.java:731)
[findbugs] Output saved to /tmp/x/trunk/build/test/findbugs/
hadoop-findbugs-report.xml
[xslt] Processing /tmp/x/trunk/build/test/findbugs/hadoop-
findbugs-report.xml to /tmp/x/trunk/build/test/findbugs/hadoop-
findbugs-report.html
[xslt] Loading stylesheet /opt/java/findbugs/src/xsl/default.xsl
[xslt] : Error! Premature end of file.
[xslt] : Error!
com.sun.org.apache.xml.internal.utils.WrappedRuntimeException:
Premature end of file.
[xslt] Failed to process /tmp/x/trunk/build/test/findbugs/
hadoop-findbugs-report.xml
BUILD FAILED
/tmp/x/trunk/build.xml:599:
javax.xml.transform.TransformerException:
javax.xml.transform.TransformerException:
com.sun.org.apache.xml.internal.utils.WrappedRuntimeException:
Premature end of file.
----
This is because
build/hadoop-0.16.0-dev-streaming.jar
is the wrong location, it should be
build/contrib/streaming/hadoop-0.16.0-dev-streaming.jar
I think this also explains why Hudson is currently giving a -1 to
all new patches as findbugs is failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
