[ 
https://issues.apache.org/jira/browse/HADOOP-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Cutting updated HADOOP-2344:
---------------------------------

    Status: Open  (was: Patch Available)

I think you mean to override Thread#run(), not Thread#start(), no?

Also, do we need both ShellUtil & ShellCommand?  It would seem less error prone 
to have a single utility for executing command lines.

I think this is a bug worth fixing.  In a previous version of DF.java, I recall 
finding that failing to explicitly close all streams could cause file 
descriptor leaks.  Now it seems that in the current version streams are no 
longer closed again.  And reading process output before checking for exit 
status also seems prudent.

> Free up the buffers (input and error) while executing a shell command before 
> waiting for it to finish.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2344
>             Project: Hadoop
>          Issue Type: Bug
>    Affects Versions: 0.15.2
>            Reporter: Amar Kamat
>             Fix For: 0.15.2
>
>         Attachments: HADOOP-2231.patch
>
>
> Process.waitFor() should be invoked after freeing up the input and error 
> stream.  While fixing https://issues.apache.org/jira/browse/HADOOP-2231 we 
> found that this might be a possible cause.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to