[ https://issues.apache.org/jira/browse/HADOOP-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549523 ]
Hadoop QA commented on HADOOP-544: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12371240/id_v1.patch against trunk revision r602002. @author +1. The patch does not contain any @author tags. javadoc -1. The javadoc tool appears to have generated messages. javac +1. The applied patch does not generate any new compiler warnings. findbugs -1. The patch appears to introduce 5 new Findbugs warnings. core tests -1. The patch failed core unit tests. contrib tests -1. The patch failed contrib unit tests. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1296/testReport/ Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1296/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1296/artifact/trunk/build/test/checkstyle-errors.html Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1296/console This message is automatically generated. > Replace the job, tip and task ids with objects. > ----------------------------------------------- > > Key: HADOOP-544 > URL: https://issues.apache.org/jira/browse/HADOOP-544 > Project: Hadoop > Issue Type: Improvement > Components: mapred > Affects Versions: 0.6.2 > Reporter: Owen O'Malley > Assignee: Enis Soztutar > Fix For: 0.16.0 > > Attachments: id_v1.patch, id_wip1.patch > > > I think that it is silly to have tools parsing the strings that the framework > builds for task ids. I propose: > class JobId implements Writable { > public int getJobId() {...} > } > class TaskId implements Writable { > public JobId getJobId(); > public boolean isMap() { ... } > public int getTaskId() { ... } > } > class TaskAttemptId implements Writable { > public TaskId getTaskId(); > public int getAttemptId(); > } > each of the classes will have a toString() method that generates the current > string. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.