[ 
https://issues.apache.org/jira/browse/HADOOP-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552623
 ] 

Amar Kamat commented on HADOOP-2344:
------------------------------------

{quote}
A few questions about naming:

    * should we move this class to the util package, since it's not fs-specific?
{quote}
+1, since we are using it like a _shell_. 
{quote} *  should SimpleCommandExecutor#getResponse() instead be named 
getOutput()?{quote}
Did you mean {{SimpleCommandExecutor#getReply()}}?  
{{output}} is more appropriate as in _output of a command (execution)_. 



> Free up the buffers (input and error) while executing a shell command before 
> waiting for it to finish.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2344
>             Project: Hadoop
>          Issue Type: Bug
>    Affects Versions: 0.15.2
>            Reporter: Amar Kamat
>            Assignee: Amar Kamat
>             Fix For: 0.15.2
>
>         Attachments: HADOOP-2231.patch, HADOOP-2344.patch, HADOOP-2344.patch, 
> HADOOP-2344.patch
>
>
> Process.waitFor() should be invoked after freeing up the input and error 
> stream.  While fixing https://issues.apache.org/jira/browse/HADOOP-2231 we 
> found that this might be a possible cause.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to