[
https://issues.apache.org/jira/browse/HADOOP-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553523
]
rangadi edited comment on HADOOP-2398 at 12/19/07 2:38 PM:
----------------------------------------------------------------
A few comments :
# Remove LOG.debug() after inovke() in RPC.java
# rpcDiscardedOps is not treated/named consistently compared to other two
variables in RpcMetrics and RpcMgt. Also it is not updated or reset.
# RpcMetrics.log should be called LOG.
# As you mentione in the conversation, right now RpcMgtMBean interfaces and the
access methods in RpcMgt are quired by JMX. Once we move to "Dyncalic MBean"
stuff most of it will go away. Same for NameNodeMgt and NameNodeMBean.
registerMBean() could be in utils.
# createFile() etc in NameNodeMetrics don't need to be synchronized.
Edit: Typos.
was (Author: rangadi):
A few comments :
# Remove LOG.debug() after inovke() in RPC.java
# rpcDiscardedOps is not treated/named consistently compared to other two
variables in RpcMetrics and RpcMgt. Also is is is not updated or reset.
# RpcMetrics.log should be called LOG.
# As you mentione in the conversation, right now RpcMgtMBean interfaces and the
access methods in RpcMgt are quired by JMX. Once we move to "Dyncalic MBean"
stuff most of it will go away. Same for NameNodeMgt and NameNodeMBean.
registerMBean() could be in utils.
# createFile() etc in NameNodeMetrics don't need to be synchronized.
> Additional Instrumentation for NameNode, RPC Layer and JMX support
> -------------------------------------------------------------------
>
> Key: HADOOP-2398
> URL: https://issues.apache.org/jira/browse/HADOOP-2398
> Project: Hadoop
> Issue Type: New Feature
> Components: dfs
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.16.0
>
> Attachments: metricsPatch6.txt, ScreenShotNameNodeStats.png,
> ScreenShotRPCStats.png
>
>
> Additional Instrumentation is needed for name node and its rpc layer.
> Furthermore the instrumentation should be
> visible via JMX, Java's standard monitoring tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
