[ 
https://issues.apache.org/jira/browse/HADOOP-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553875
 ] 

dhruba borthakur commented on HADOOP-2336:
------------------------------------------

A few generic comments:

1. Maybe it makes more sense to introduce the new class in a separate source 
file, e.g. FsShellPermissions.java. This will keep FsShell.java more manageable 
in size.

2. The ListPathServlet uses the wrong attribute named "onwer".

3. It might be more robust to handle the default cases in most switch 
statements to raise an exception. e.g. in changePermissions().

I am still chewing on the changes to FileStatus. 

> Shell commands to access and modify file permissions
> ----------------------------------------------------
>
>                 Key: HADOOP-2336
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2336
>             Project: Hadoop
>          Issue Type: New Feature
>          Components: fs
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2336.patch, HADOOP-2336.patch, HADOOP-2336.patch, 
> HADOOP-2336.patch, HADOOP-2336.patch
>
>
> Hadoop 0.16 includes file permissions in DFS and we need FsShell to support 
> common file permissions related commands :
> - chown
> - chgrp
> - chmod
> Also output from some of the commands like {{ls -l}} will change to reflect 
> new file properties. Aim is to make the above commands look like its 
> Unix/Linux couterparts. They will of course support only the subset of the 
> options.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to