[ 
https://issues.apache.org/jira/browse/HADOOP-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun C Murthy updated HADOOP-2268:
----------------------------------

    Status: Open  (was: Patch Available)

I'm sorry to jump in late, I was reviewing this patch with the intention of 
committing it and noticed some white-space related changes... I do feel bad 
about cancelling this patch.

Bigger picture: To be honest, I really don't see this improving things that 
much. I'd still go with breaking compatibility and changing the signatures, 
since it really is the only way but for new method names. That said, I won't 
stand in way of this patch if others don't agree.

> JobControl classes should use interfaces rather than implemenations
> -------------------------------------------------------------------
>
>                 Key: HADOOP-2268
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2268
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.15.0
>            Reporter: Adrian Woodhead
>            Assignee: Adrian Woodhead
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2268-1.patch, HADOOP-2268-2.patch, 
> HADOOP-2268-3.patch
>
>
> See HADOOP-2202 for background on this issue. Arun C. Murthy agrees that when 
> possible it is preferable to program against the interface rather than a 
> concrete implementation (more flexible, allows for changes of the 
> implementation in future etc.) JobControl currently exposes running, waiting, 
> ready, successful and dependent jobs as ArrayList rather than List. I propose 
> to change this to List.
> I will code up a patch for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to