[
https://issues.apache.org/jira/browse/HADOOP-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553980
]
Hadoop QA commented on HADOOP-2268:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12372086/HADOOP-2268-4.patch
against trunk revision r606058.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1418/testReport/
Findbugs warnings:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1418/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1418/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1418/console
This message is automatically generated.
> JobControl classes should use interfaces rather than implemenations
> -------------------------------------------------------------------
>
> Key: HADOOP-2268
> URL: https://issues.apache.org/jira/browse/HADOOP-2268
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.15.0
> Reporter: Adrian Woodhead
> Assignee: Adrian Woodhead
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2268-1.patch, HADOOP-2268-2.patch,
> HADOOP-2268-3.patch, HADOOP-2268-4.patch
>
>
> See HADOOP-2202 for background on this issue. Arun C. Murthy agrees that when
> possible it is preferable to program against the interface rather than a
> concrete implementation (more flexible, allows for changes of the
> implementation in future etc.) JobControl currently exposes running, waiting,
> ready, successful and dependent jobs as ArrayList rather than List. I propose
> to change this to List.
> I will code up a patch for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
