[
https://issues.apache.org/jira/browse/HADOOP-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555627#action_12555627
]
Raghu Angadi commented on HADOOP-2512:
--------------------------------------
> 2) The way the Exception message is composed should be changed.
I don't see any difference other than adding a "\n", is that true?
> 3) In the patch you are waiting for the error stream to finish with the
> output stream still open. This could possibly lead to a deadlock
Not really, the process has already exited. This patch has the same guarantees
as when waitFor() returning '0'.
> [...] the rest [...]
What is the issue with the current patch? If you think errMsg is not important,
then we should not try to put it in IOException, right?
> error stream handling in Shell executor
> ----------------------------------------
>
> Key: HADOOP-2512
> URL: https://issues.apache.org/jira/browse/HADOOP-2512
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Affects Versions: 0.16.0
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.16.0
>
> Attachments: HADOOP-2512.patch
>
>
> Fix a couple of issues while handling error stream in Shell (added in
> HADOOP-2344) :
> # fix typo in {{System.getProperty("line.seperator")}}, currently it adds
> "null" instead of "\n".
> # completed is not set to {{true}} when a process exits with an error.
> # In normal error case, it reads errMsg (to create IOException) before
> waiting for errThread to complete, which results in in consistent error
> message. I will attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
