[ 
https://issues.apache.org/jira/browse/HADOOP-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557108#action_12557108
 ] 

Konstantin Shvachko commented on HADOOP-2385:
---------------------------------------------

We already have JobConf derived from Configuration.
I am just proposing to extend this approach to other components.
The Configuration itself should remain the same for each component.
That is it reads the same config files with the same override rules, and with 
the same properties inside.
It just exposes get methods specific to the component.
Conversion from one class to another can be easily provided by constructors 
like 
{code} FsConfiguration(Configuration conf) {code}
And then you can pass RPCCongifuration as a parameter into it since the latter 
is a subclass of Configuration and since it contains all properties related to 
rpc.
So configuration class for each component is just a wrapper exposing methods and
providing validation and potentially conversion of the parameters related to 
the component.
I do not support the idea of placing static getters for configuration 
parameters in the (top-level) component 
classes because I would prefer to separate all configuration issues from the 
component code.
FSNamesystem is again almost 4K lines long, JobTracker and TaskTracker over 2K 
lines.


> Validate configuration parameters
> ---------------------------------
>
>                 Key: HADOOP-2385
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2385
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>
> Configuration parameters should be fully validated before name nodes or data 
> nodes begin service.
> Required parameters must be present.
> Required and optional parameters must have values of proper type and range.
> Undefined parameters must not be present.
> (I was recently observing some confusion whose root cause was a mis-spelled 
> parameter.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to