[ 
https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559362#action_12559362
 ] 

hrishikesh edited comment on HADOOP-2509 at 1/15/08 10:34 PM:
--------------------------------------------------------------

   If rat.Report exists and gets executed (assuming all the required libraries 
are in place) but finds missing license headers the JVM which executes 
rat.Report will still exit with error code 0. So checking the JVM exist code is 
of no help. 

We can either look for text in the rat.Report output and then fail if say a 
word XXX exists or we write our own ant task which extends the functionality of 
rat.Report and then  exist with System.exit (1) when any issues are found. This 
needs further investigation.




      was (Author: hrishikesh):
       If rat.Report exists and gets executed (assuming all the required 
libraries are in place) but finds missing license headers the JVM which 
executes rat.Report will still exit with error code 0. So checking the JVM 
exist code is of no help. 

We can either look for text in the rat.Report output and then fail if say a 
word XXX exists or we write our own ant task which extends rat.Report and then 
write code to exist with System.exit (1) when any issues are found. This needs 
further investigation.



  
> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed 
> for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to