On 9/24/07, Nigel Daley <[EMAIL PROTECTED]> wrote: > > On Sep 22, 2007, at 4:35 PM, kate rhodes wrote: > > > https://issues.apache.org/jira/browse/HADOOP-1936 > > contrib tests -1. The patch failed contrib unit tests. > > There are know stability issues with the contrib unit tests on the > Solaris build machine. Committers can make a judgment call when they > commit.
Sorry, I'm not following... do you mean that the thing that decides if a unit test is present has stability issues or that the unit tests that are typically found in contrib have stability issues? > > > The patch WAS unit tests. Actually it was one unit test, one new > > class, and one test for the new class. > > Your test was never run. I suggest you move it to > src/test/org/apache/hadoop/examples > both because I think it makes more sense there > and it will get picked up by the existing > ant test target. Ok, I can do that tonight, but I'm still in the dark as to what I could have done to not get the penalty if that was the correct place for it. Also If it's not going to bother to test in there then it shouldn't penalize patches for files in that/those directories. -- - kate = masukomi http://weblog.masukomi.org/
