That seems reasonable. All of those functions could be looked at as "common."
The intention was to group together a bunch of functions that were useful for packet formatting. Although the bulk of the formatting is done by XDR, there are some things that XDR doesn't do, like generating and checking SHA sums. cld_dump_buf and cld_pkt_hdr_to_str are purely for debugging purposes, but they seemed like something that would be generally useful for developers making packet format changes. I know that they were useful to me. Colin On Thu, Jan 28, 2010 at 11:01 PM, Jeff Garzik <[email protected]> wrote: > Oh, FYI, I am also folding cld_fmt.h into cld_common.h. One less header, > and the contents of cld_fmt.h did not really seem to align perfectly with > the implied mnemonic "cld format" IMO. > > Jeff > > > > > -- To unsubscribe from this list: send the line "unsubscribe hail-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
