Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Hama Wiki" for change 
notification.

The following page has been changed by udanax:
http://wiki.apache.org/hama/HowToCommit

New page:
= Guide for Hama Committers =

This page contains guidelines for committers.

== Review ==

Hama committers should, as often as possible, attempt to review patches 
submitted by others.  Ideally every submitted patch will get reviewed by a 
committer within a few days.  If a committer reviews a patch they've not 
authored, and believe it to be of sufficient quality, then they can commit the 
patch, otherwise the patch should be cancelled with a clear explanation for why 
it was rejected.

For non-trivial changes, it is best to get another committer to review your own 
patches before commit. Use "Submit Patch" like other contributors, and then 
wait for a "+1" from another committer before committing.

== Reject ==

Patches should be rejected which do not adhere to the guidelines in 
HowToContribute and to the CodeReviewChecklist.  Committers should always be 
polite to contributors and try to instruct and encourage them to contribute 
better patches.  If a committer wishes to improve an unacceptable patch, then 
it should first be rejected, and a new patch should be attached by the 
committer for review.

== Commit ==

When you commit a patch, please:

 1. Add an entry in CHANGES.txt, at the end of the appropriate section.  This 
should include the Jira issue id, and the name of the contributor.
 1. Include the Jira issue id in the commit message, along with a short 
description of the change and the name of the contributor if it is not you.  Be 
sure to get the issue id right, as this causes Jira to link to the change in 
Subversion (use the issue's "All" tab to see these).
 1. Resolve the issue as fixed, thanking the contributor.  Always set the "Fix 
Version" at this point, but please only set a single fix version, the earliest 
release in which the change will appear.

Reply via email to