[
https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674550#action_12674550
]
Edward J. Yoon commented on HAMA-153:
-------------------------------------
As you said, matrix addition require the conformability. So, your patch looks
great.
>> BTW, should we need a test case for addition-check?
If we add a test case for it, I would believe we can find more easily an
related code bugs.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch,
> HAMA-153_v04.patch
>
>
> some conditions will be checked before we construct the result matrix and
> compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
