I've committed the patch. Everything seems fine to me. Feedback appreciated :-) Tommaso
p.s. Maybe we should look at NOTICE/LICENSE files for each module by next release to make sure everything is ok. 2011/8/1 Edward J. Yoon <[email protected]> > +1 > > On Mon, Aug 1, 2011 at 5:00 PM, Tommaso Teofili > <[email protected]> wrote: > > I'll go on committing the patch by the end of the day if no one objects. > > Tommaso > > > > 2011/8/1 Tommaso Teofili <[email protected]> > > > >> Thanks Edward, I'll update the patch :) > >> Tommaso > >> > >> 2011/8/1 Edward J. Yoon <[email protected]> > >> > >> >> I can't reproduce the error with testjob, Edward can you specify how > to > >>> >> reproduce that? > >>> > >>> I found it can be fixed by adding "System.getProperty("user.dir")" to > >>> "TEST_JOB" path of TestBSPMasterGroomServer. > >>> > >>> 58 line: bsp.setJar(System.getProperty("user.dir") + "/" + TEST_JOB); > >>> > >>> On Fri, Jul 29, 2011 at 9:25 PM, Edward J. Yoon <[email protected] > > > >>> wrote: > >>> > Yes sir~! > >>> > > >>> > On Fri, Jul 29, 2011 at 9:23 PM, Tommaso Teofili > >>> > <[email protected]> wrote: > >>> >> I found myself a problem with src/webapps path written inside > >>> HttpServer. > >>> >> Will move src/webapps to src/main/webapp as this is the default > Maven > >>> >> location for jsp files. > >>> >> I can't reproduce the error with testjob, Edward can you specify how > to > >>> >> reproduce that? > >>> >> Thanks > >>> >> Tommaso > >>> >> > >>> >> 2011/7/29 Edward J. Yoon <[email protected]> > >>> >> > >>> >>> Rest are very nice I'm +1 :D > >>> >>> > >>> >>> [INFO] Reactor Summary: > >>> >>> [INFO] > >>> >>> [INFO] Apache Hama parent POM ............................ SUCCESS > >>> [0.691s] > >>> >>> [INFO] Apache Hama Core .................................. SUCCESS > >>> >>> [27.276s] > >>> >>> [INFO] Apache Hama Examples .............................. SUCCESS > >>> [4.733s] > >>> >>> [INFO] > >>> >>> > >>> > ------------------------------------------------------------------------ > >>> >>> [INFO] BUILD SUCCESS > >>> >>> [INFO] > >>> >>> > >>> > ------------------------------------------------------------------------ > >>> >>> [INFO] Total time: 32.837s > >>> >>> [INFO] Finished at: Fri Jul 29 21:00:17 KST 2011 > >>> >>> [INFO] Final Memory: 21M/130M > >>> >>> > >>> >>> On Fri, Jul 29, 2011 at 9:03 PM, Edward J. Yoon < > >>> [email protected]> > >>> >>> wrote: > >>> >>> > I found one error message: "File > src/test/java/testjar/testjob.jar > >>> >>> > does not exist." > >>> >>> > > >>> >>> > Does anyone have a idea to get rid of this jar file? or to get > base > >>> >>> directory? > >>> >>> > > >>> >>> > On Fri, Jul 29, 2011 at 7:44 PM, Tommaso Teofili > >>> >>> > <[email protected]> wrote: > >>> >>> >> Hello again, > >>> >>> >> I've opened HAMA-417 [1] and supplied a patch. > >>> >>> >> Before committing it, I ask you to review it as it's a pretty > huge > >>> >>> >> refactoring. > >>> >>> >> Then I can go on either committing it on trunk or creating a > >>> separate > >>> >>> branch > >>> >>> >> which can be merged back to trunk afterwards. > >>> >>> >> Cheers, > >>> >>> >> Tommaso > >>> >>> >> > >>> >>> >> [1] : https://issues.apache.org/jira/browse/HAMA-417 > >>> >>> >> > >>> >>> >> 2011/7/29 Tommaso Teofili <[email protected]> > >>> >>> >> > >>> >>> >>> Hi al, > >>> >>> >>> I'd like to start the refactoring we discussed some time ago in > >>> order > >>> >>> to > >>> >>> >>> create different modules for hama-core and hama-examples, this > >>> should > >>> >>> also > >>> >>> >>> help any future factoring out of functionalities in more fine > >>> grained > >>> >>> >>> modules. > >>> >>> >>> What do you think? > >>> >>> >>> Regards, > >>> >>> >>> Tommaso > >>> >>> >>> > >>> >>> >> > >>> >>> > > >>> >>> > > >>> >>> > > >>> >>> > -- > >>> >>> > Best Regards, Edward J. Yoon > >>> >>> > @eddieyoon > >>> >>> > > >>> >>> > >>> >>> > >>> >>> > >>> >>> -- > >>> >>> Best Regards, Edward J. Yoon > >>> >>> @eddieyoon > >>> >>> > >>> >> > >>> > > >>> > > >>> > > >>> > -- > >>> > Best Regards, Edward J. Yoon > >>> > @eddieyoon > >>> > > >>> > >>> > >>> > >>> -- > >>> Best Regards, Edward J. Yoon > >>> @eddieyoon > >>> > >> > >> > > > > > > -- > Best Regards, Edward J. Yoon > @eddieyoon >
