[
https://issues.apache.org/jira/browse/HAMA-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215574#comment-13215574
]
Thomas Jungblut commented on HAMA-498:
--------------------------------------
Oh crap, I believe it was like this times ago... Thanks for making it right.
Localrunner does this wrong as well.
But the YARN runner makes it correctly!
{noformat}
public void startComputation() throws Exception {
BSP bspInstance = ReflectionUtils.newInstance(bspClass, conf);
try {
bspInstance.setup(peer);
bspInstance.bsp(peer);
} catch (Exception e) {
throw e;
} finally {
bspInstance.cleanup(peer);
peer.close();
}
}
{noformat}
And that is the way it actually should be (in my opinion).
> BSPTask should periodically ping its parent.
> --------------------------------------------
>
> Key: HAMA-498
> URL: https://issues.apache.org/jira/browse/HAMA-498
> Project: Hama
> Issue Type: Sub-task
> Components: bsp
> Affects Versions: 0.4.0
> Reporter: Edward J. Yoon
> Assignee: Suraj Menon
> Labels: newbie
> Fix For: 0.5.0
>
>
> As described in http://wiki.apache.org/hama/GroomServerFaultTolerance
> BSPTask should periodically ping its parent 'GroomServer' for their health
> status.
> 1. If Tasks are unable to ping their parent 'GroomServer', it should be
> killed themselves.
> 2. And, if GroomServer does not receive ping from the childs, GroomServer
> should check whether that child is running.
> You don't need to implement recovery logic in this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira