1. Thanks for sending them in!
2. Done.
3. Another good catch - this is definitely not the right behavior. I've
committed your patch.
Thanks,
- Nathan
Tom Stuart wrote:
> Hey,
>
> 1. Thanks for applying my patches from yesterday!
>
> 2. Could test/sass/templates/parent_ref.sass be added, please, so
> that its test passes?
>
> 3. Attached is a patch to the behaviour of the :nested style. The
> existing indentation is, I think, misleading in some cases; e.g.
>
> .content
> :border
> :right 1px
> :bottom 2px
> h1
> :font-size 48pt
> .post
> .header
> :border-style solid
> .body
> :border-style dotted
> .footer
> :border-style dashed
>
> renders as
>
> .content {
> border-right: 1px;
> border-bottom: 2px; }
>
> .content h1 {
> font-size: 48pt; }
>
> .post .header {
> border-style: solid; }
> .post .header {
> border-style: dotted; }
> .post .header {
> border-style: dashed; }
>
> which, at a glance, looks superficially as though the '.post *' rules
> have been (incorrectly) nested within the '.content' rule. The
> natural remedy seems to be to not increase the indent of subrules if
> the current rule contains no attributes (and hence won't be rendered
> at all), so that the output instead looks like
>
> .content {
> border-right: 1px;
> border-bottom: 2px; }
>
> .content h1 {
> font-size: 48pt; }
>
> .post .header {
> border-style: solid; }
> .post .header {
> border-style: dotted; }
> .post .header {
> border-style: dashed; }
>
> which I (personally) think is clearer. The attached patch makes this
> change to RuleNode::to_s, and the nested rendering test now tests
> this behaviour.
>
> Cheers,
> -Tom
>
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Haml" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/haml?hl=en
-~----------~----~----~----~------~----~------~--~---
