I don't want to add tests that'll only pass for one Rails version. If you can make tests that pass for all versions of Rails, but fail for at least some without this patch, then go for it, but otherwise don't worry about it.
I'll patch this in soon - see my message about internet access. - Nathan On Jan 12, 2008 4:41 PM, RSL <[EMAIL PROTECTED]> wrote: > > I just realized I forgot to make a note that I wrote no tests for this > as it passes already. Sadly, it also passes before my patch so we > might need some regression tests [is that the right phrase?] or > something. I dunno. Lemme know if you want me to write up [ie, invent] > tests for it or if I need to change anything else. Yay, my first Haml > patch! > > RSL > > On Jan 12, 1:19pm, "Russell Norris" <[EMAIL PROTECTED]> wrote: > > Index: lib/haml/template/plugin.rb > > =================================================================== > > --- lib/haml/template/plugin.rb (revision 727) > > +++ lib/haml/template/plugin.rb (working copy) > > @@ -7,7 +7,19 @@ > > def self.line_offset > > 1 > > end > > + > > + def self.compilable? > > + true > > + end > > + > > + def compilable? > > + self.class.compilable? > > + end > > > > + def line_offset > > + self.class.line_offset > > + end > > + > > def initialize(view) > > @view = view > > end > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Haml" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/haml?hl=en -~----------~----~----~----~------~----~------~--~---
