Hi Michal, On Tue, Apr 11, 2017 at 04:41:25PM +0200, Michal wrote: > Hello Willy, > > So I'm fighting with dba97077 made by Frédéric Lécaille - it broke many > things.
That's the principle of distributed development : better get your changes in shape first so that you don't have to adapt to others' changes. > E.g. you can't use "source", because that patch broke it. I'm curious how > many other stuff got broken with those patches around default-server. Well, for having reviewed this patch set in depth, I didn't spot anything obvious. That doesn't mean there's no bug, it's just that I didn't notice any. > We need some CI (even if they will only build haproxy) and IMHO people with > @haproxy.com mails should test their code before posting and merging :( Well, all people test their code, but there are countless combinations of possible breakage. There's a reason why this version is still in development so your comment suggesting that people don't work the way you'd do it is totally inappropriate. And in case you're wondering, we're still in development and there will be more breakage to come. That's the principle of a development branch. > In attachment there is patch fixed after your (Willy) review. Sorry for > loop, > I was focused on fixing all those problems with Frédérics patch I just > didn't > think how to replace do..while (which obviously works) with this cleaner > version - thanks for this. The patch got even simpler. If you don't mind I'll retag it "MEDIUM" because it will definitely impact some users since it's a behaviour change. I'll review the patch ASAP. Thanks, Willy
