you are right.

let us exclude that particular test from freebsd (what your patch exactly
does)

вт, 30 апр. 2019 г. в 13:57, Илья Шипицин <[email protected]>:

>
>
> вт, 30 апр. 2019 г. в 13:32, Frederic Lecaille <[email protected]>:
>
>> On 4/30/19 10:04 AM, Илья Шипицин wrote:
>> > Hello, Frederic
>> >
>> > I have applied only that part
>> >
>> >   barrier b cond 3
>> > @@ -29,7 +30,7 @@ syslog S3 -level notice {
>> >       recv
>> >       expect ~ "[^:\\[ ]\\[${h1_pid}\\]: Proxy be3 started"
>> >       recv
>> > -    expect ~ "[^:\\[ ]\\[${h1_pid}\\]: Health check for server
>> be3/srv3
>> > failed, reason: Layer4 .* check duration: [[:digit:]]+ms, status: 0/1
>> DOWN."
>> > +    expect ~ "[^:\\[ ]\\[${h1_pid}\\]: Health check for server
>> be3/srv3
>> > failed, reason: Layer4 connection problem, info: \"General socket error
>> > \\(Network is unreachable\\)\", check duration: [[:digit:]]+ms, status:
>> > 0/1 DOWN."
>> >   } -start
>> >
>> >
>> > it works, test is green now (on freebsd)
>> >
>> >
>> > https://cirrus-ci.com/task/6252507322908672
>> >
>> > пн, 29 апр. 2019 г. в 19:14, Frederic Lecaille <[email protected]
>> > <mailto:[email protected]>>:
>> >
>> >     On 4/29/19 3:56 PM, Илья Шипицин wrote:
>> >      > well, in cirrus-ci we can choose several freebsd images. I just
>> >     picked
>> >      > up the most recent one.
>> >      >
>> >      > I'll try older images soon.
>> >      >
>> >      > actually, there are several options
>> >      >
>> >      > 1) add special "ignore" to those tests (can we ignore certain
>> >     tests, for
>> >
>> >     Well this reg test was originally Linux specific.
>> >
>> >     With the patch attached we can make it be Linux specific again.
>> >
>> >
>> >     Fred.
>> >
>>
>> Hello Ilya,
>>
>> I am not sure to understand everything.
>>
>
> I did play with output from various cirrus-ci steps and I forgot that
> script currently looks like
>
>   script:
>     - pkg install openssl111 git gmake lua53
> #    - git clone https://github.com/VTest/VTest.git ../vtest
> #    - make -C ../vtest
> #    - gmake CC=clang V=1 TARGET=freebsd USE_ZLIB=1 USE_PCRE=1
> USE_OPENSSL=1 USE_LUA=1 LUA_INC=/usr/local/include/lua53
> LUA_LIB=/usr/local/lib LUA_LIB_NAME=lua-5.3
> #    - ./haproxy -vv
> #    - ldd haproxy
> #    - env VTEST_PROGRAM=../vtest/vtest gmake reg-tests || for folder in
> /tmp/*regtest*/vtc.*; do cat $folder/INFO $folder/LOG; done
>
> I'll test later
>
>
>
>>
>> In fact the patch I sent is supposed to disable the reg test on freebsd
>> because it also restores a Linux specific regex on syslog messages. The
>> reg test should not be run on FreeBSD, thanks to this patch. The part of
>> the patch you applied is Linux specific. If you do not take the other
>> part of the patch, the reg test is not disabled on freebsd. So it should
>> fail contrary to what you reported.
>> https://cirrus-ci.com/build/6289311702974464 does not demonstrate the
>> reg test succeeds. Isn't this  only a build report? If I use the task ID
>> 6252507322908672 and have a look at the log here:
>>
>> https://api.cirrus-ci.com/v1/task/6252507322908672/logs/main.log
>>
>> I do not see any reg test result.
>>
>>
>> Fred.
>>
>>
>>
>>

Reply via email to