Hello Willy,
On Mon, 6 May 2019 at 08:06, Willy Tarreau <[email protected]> wrote: > > Hi Ilya, > > > I made another PR > > > > https://github.com/haproxy/haproxy/pull/92 > > Thank you. > > > (I really like automatic PR to mailing list routing) > > Well, it was the only workable workaround we have when people send PRs. > Sadly we can't block them. Apparently only mirror repositories can block > PRs and github doesn't accept to create them anymore. But when there are > multiple patches in the PR it's not usable as-is anymore, it only serves > as a notification that someone sent something. > > For me, PRs tremendously increase the amount of manipulations, which is > why I tend to postpone them until I think this will not divert me too > much from what I am doing. I just timed the operations on this small > batch and it went from ~15 seconds to review and merge your 4 patches > if they were in mails (just pressing Enter in mutt to review them, > possibly "e" to quickly edit if needed, and "A" to apply), then "g" to > ack the merge, to around 3 minutes to : There is room for improvement here. Can you confirm that attaching a patch file per commit to the email would fix this usability issue? I just finally fixed the script for authors with non-ascii names (it crashed previously), I can add the file attachments to my todo list, if useful. Lukas
