Hi Christopher And Willy,
Please review the RT test results.
Thanks,
Kiran Gavali
-----Original Message-----
From: Kiran Gavali
Sent: Monday, March 30, 2020 6:59 PM
To: Christopher Faulet <[email protected]>; Willy Tarreau <[email protected]>
Cc: [email protected]; Shivharsh Singh <[email protected]>;
Priya Ranjan <[email protected]>; Ramanpreet Singh Bakshi
<[email protected]>; Kiran Gavali <[email protected]>
Subject: RE: [RFC] BUG/MEDIUM: Checks: support for HTTP health checks with POST
and data corrupted by extra connection close
Thank you Christopher for providing HAProxy reg-test suite !
>About the regression tests, we use varnishtest
>(https://github.com/vtest/VTest).
>All our tests are placed in the "reg-tests" subdirectory. Here is a
>documentation to write VTC tests:
>https://varnish-cache.org/docs/trunk/reference/vtc.html.
>To run tests, you may use the script "scripts/run-regtests.sh" or the "make
>reg-tests" command.
We have executed the regression tests using varnishtest
(https://github.com/vtest/VTest).
Please find the attached HAProxy regression test result, there is no any test
case failed , All tests are passed.
########################## Starting vtest ########################## Testing
with haproxy version: 2.2-dev4-0576db-97
0 tests failed, 0 tests skipped, 62 tests passed
Please confirm the RT execution and suggest us further any work is need to
resolve this bug.
Thanks,
Kiran Gavali
-----Original Message-----
From: Christopher Faulet [mailto:[email protected]]
Sent: Thursday, March 26, 2020 2:15 PM
To: Kiran Gavali <[email protected]>; Willy Tarreau <[email protected]>
Cc: [email protected]; Shivharsh Singh <[email protected]>;
Priya Ranjan <[email protected]>; Ramanpreet Singh Bakshi
<[email protected]>
Subject: Re: [RFC] BUG/MEDIUM: Checks: support for HTTP health checks with POST
and data corrupted by extra connection close
Le 26/03/2020 à 09:24, Kiran Gavali a écrit :
> Thank you Christopher and Willy for your responses !
>
> We have discussed the resolution for the issue on GitHub at following
> link: https://github.com/haproxy/haproxy/issues/16
> However to further explain the patch fix, we have introduced new options,
> "header" and "body" in http-check directive. Based on the content for these
> options configured in haproxy.cfg and if expect option is also configured for
> http-check, the header is added to a buffer followed by the "Connection:
> close" string which is further followed by the body.
> For cases, when either header or body or both is not configured in
> haproxy.cfg, we have used default values to create the data packet in the
> buffer.
> We would definitely update the documentation once the patch is finalized and
> therefore shared it with RFC tag.
Ah, ok. I understand now. I missed the RFC tag in the email subject, sorry :)
>
> To answer your query on reg-test, We have performed regression testing of
> the patch using the RT suite available at our end. We can share with you the
> test report, if required. However, if there is any community RT suite that
> you would like us to follow, please do let me know.
>
About the regression tests, we use varnishtest (https://github.com/vtest/VTest).
All our tests are placed in the "reg-tests" subdirectory. Here is a
documentation to write VTC tests:
https://varnish-cache.org/docs/trunk/reference/vtc.html.
To run tests, you may use the script "scripts/run-regtests.sh" or the "make
reg-tests" command.
> As far as the relevance of this patch is concerned, considering the
> planned http-check refactoring at your end, we were already aware that
> the patch might not be merged due to the fact that the check system
> is currently being reworked to support muxes for HTTP/1 and HTTP/2 so
> that there are better checks in 2.2
>
As Willy said, have a solution for current versions is also important. But the
syntax must be compatible with the next one. This part must be discussed first.
--
Christopher Faulet
________________________________
The contents of this e-mail and any attachment(s) are confidential and
intended for the named recipient(s) only. It shall not attach any liability on
the originator or NECTI or its affiliates. Any views or opinions presented in
this email are solely those of the author and may not necessarily reflect the
opinions of NECTI or its affiliates. Any form of reproduction, dissemination,
copying, disclosure, modification, distribution and / or publication of this
message without the prior written consent of the author of this e-mail is
strictly prohibited. If you have received this email in error please delete it
and notify the sender immediately.
[root@haproxy haproxy]# sh scripts/run-regtests.sh
########################## Preparing to run tests ##########################
Testing with haproxy version: 2.2-dev4-0576db-97
Target : linux-glibc
Options : +EPOLL -KQUEUE +NETFILTER +PCRE +PCRE_JIT -PCRE2 -PCRE2_JIT +POLL
-PRIVATE_CACHE +THREAD -PTHREAD_PSHARED +BACKTRACE -STATIC_PCRE -STATIC_PCRE2
+TPROXY +LINUX_TPROXY +LINUX_SPLICE +LIBCRYPT +CRYPT_H +GETADDRINFO +OPENSSL
+LUA +FUTEX +ACCEPT4 +ZLIB -SLZ +CPU_AFFINITY +TFO +NS +DL +RT -DEVICEATLAS
-51DEGREES -WURFL -SYSTEMD -OBSOLETE_LINKER +PRCTL +THREAD_DUMP -EVPORTS
########################## Gathering tests to run ##########################
Add test: reg-tests/cache/basic.vtc
Add test: reg-tests/checks/1be_40srv_odd_health_checks.vtc
Add test: reg-tests/checks/40be_2srv_odd_health_checks.vtc
Add test: reg-tests/checks/4be_1srv_health_checks.vtc
Add test: reg-tests/checks/4be_1srv_smtpchk_httpchk_layer47errors.vtc
Add test: reg-tests/checks/http-monitor-uri.vtc
Add test: reg-tests/checks/tcp-check_multiple_ports.vtc
Add test: reg-tests/checks/tls_health_checks.vtc
Add test: reg-tests/compression/basic.vtc
Add test: reg-tests/compression/etags_conversion.vtc
Add test: reg-tests/compression/lua_validation.vtc
Add test: reg-tests/compression/vary.vtc
Add test: reg-tests/connection/dispatch.vtc
Add test: reg-tests/connection/proxy_protocol_random_fail.vtc
Add test: reg-tests/connection/proxy_protocol_send_unique_id.vtc
Add test: reg-tests/connection/proxy_protocol_tlv_validation.vtc
Add test: reg-tests/converter/field.vtc
Add test: reg-tests/converter/sha2.vtc
Add test: reg-tests/http-capture/multiple_headers.vtc
Add test: reg-tests/http-cookies/cookie_insert_indirect.vtc
Add test: reg-tests/http-errorfiles/http_deny_errors.vtc
Add test: reg-tests/http-errorfiles/http_errors.vtc
Add test: reg-tests/http-errorfiles/http_return.vtc
Add test: reg-tests/http-messaging/h1_to_h1.vtc
Add test: reg-tests/http-messaging/h2_to_h1.vtc
Add test: reg-tests/http-messaging/http_msg_full_on_eom.vtc
Add test: reg-tests/http-messaging/http_request_buffer.vtc
Add test: reg-tests/http-rules/converters_ipmask_concat_strcmp_field_word.vtc
Skip reg-tests/http-rules/h1_to_h1c.vtc because option haproxy is version:
2.2-dev4-0576db-97
REASON: this test requires a version below: 1.9
Add test: reg-tests/http-rules/h1or2_to_h1c.vtc
Add test: reg-tests/http-rules/http_after_response.vtc
Add test: reg-tests/http-rules/http_return.vtc
Add test: reg-tests/http-rules/map_redirect.vtc
Add test: reg-tests/http-rules/map_regm_with_backref.vtc
Add test: reg-tests/http-rules/strict_rw_mode.vtc
Add test: reg-tests/log/load_balancing.vtc
Add test: reg-tests/log/wrong_ip_port_logging.vtc
Add test: reg-tests/lua/bad_http_clt_req_duration.vtc
Add test: reg-tests/lua/close_wait_lf.vtc
Add test: reg-tests/lua/h_txn_get_priv.vtc
Add test: reg-tests/lua/lua_socket.vtc
Add test: reg-tests/lua/txn_get_priv.vtc
Add test: reg-tests/lua/wrong_types_usage.vtc
Add test: reg-tests/mailers/healthcheckmail.vtc
Add test: reg-tests/mcli/mcli_show_info.vtc
Add test: reg-tests/mcli/mcli_start_progs.vtc
Add test: reg-tests/peers/basic_sync.vtc
Add test: reg-tests/peers/basic_sync_wo_stkt_backend.vtc
Add test: reg-tests/peers/tls_basic_sync.vtc
Add test: reg-tests/peers/tls_basic_sync_wo_stkt_backend.vtc
Add test: reg-tests/sample_fetches/hashes.vtc
Add test: reg-tests/sample_fetches/srv_name.vtc
Add test: reg-tests/seamless-reload/abns_socket.vtc
Add test: reg-tests/server/cli_set_fdqn.vtc
Add test: reg-tests/spoe/wrong_init.vtc
Add test: reg-tests/ssl/set_ssl_cert.vtc
Add test: reg-tests/ssl/wrong_ctx_storage.vtc
Add test: reg-tests/stick-table/converteers_ref_cnt_never_dec.vtc
Add test: reg-tests/stick-table/unknown_key.vtc
Add test: reg-tests/stickiness/lb-services.vtc
Add test: reg-tests/stream/unique-id-from-proxy.vtc
Add test: reg-tests/stream/unique-id.vtc
Add test: reg-tests/webstats/webstats-scope-and-post-change.vtc
########################## Starting vtest ##########################
Testing with haproxy version: 2.2-dev4-0576db-97
0 tests failed, 0 tests skipped, 62 tests passed
[root@haproxy haproxy]#
