Willy,
please find 42 patches attached. Sending as attachments to not
completely bomb the list.
I'll leave it up to you whether you want to squash patches 0001 until 0041.
0042 is sufficiently different to warrant a dedicated commit.
Best regards
Tim Düsterhus
>From 87ca986b06663344bdb18b1db5ca69c74145a56c Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:49:33 +0200
Subject: [PATCH 01/42] CLEANUP: Fix prototype of ha_backtrace_to_stderr()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/bug.h | 4 ++--
include/haproxy/debug.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/haproxy/bug.h b/include/haproxy/bug.h
index 7a2fa81a0..45c97ba67 100644
--- a/include/haproxy/bug.h
+++ b/include/haproxy/bug.h
@@ -39,12 +39,12 @@
#ifdef DEBUG_USE_ABORT
/* abort() is better recognized by code analysis tools */
-#define ABORT_NOW() do { extern void ha_backtrace_to_stderr(); ha_backtrace_to_stderr(); abort(); } while (0)
+#define ABORT_NOW() do { extern void ha_backtrace_to_stderr(void); ha_backtrace_to_stderr(); abort(); } while (0)
#else
/* More efficient than abort() because it does not mangle the
* stack and stops at the exact location we need.
*/
-#define ABORT_NOW() do { extern void ha_backtrace_to_stderr(); ha_backtrace_to_stderr(); (*(volatile int*)1=0); } while (0)
+#define ABORT_NOW() do { extern void ha_backtrace_to_stderr(void); ha_backtrace_to_stderr(); (*(volatile int*)1=0); } while (0)
#endif
/* BUG_ON: complains if <cond> is true when DEBUG_STRICT or DEBUG_STRICT_NOCRASH
diff --git a/include/haproxy/debug.h b/include/haproxy/debug.h
index dd1668db9..c6bdd7c5d 100644
--- a/include/haproxy/debug.h
+++ b/include/haproxy/debug.h
@@ -29,7 +29,7 @@ extern unsigned int debug_commands_issued;
void ha_task_dump(struct buffer *buf, const struct task *task, const char *pfx);
void ha_thread_dump(struct buffer *buf, int thr, int calling_tid);
void ha_dump_backtrace(struct buffer *buf, const char *prefix, int dump);
-void ha_backtrace_to_stderr();
+void ha_backtrace_to_stderr(void);
void ha_thread_dump_all_to_trash();
void ha_panic();
--
2.33.0
>From d3057dd6d1ab2c4bf0018b08ba25b95689048b1e Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 00:34:34 +0200
Subject: [PATCH 02/42] CLEANUP: Fix prototype of ha_cpuset_size()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/cpuset.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/cpuset.h b/include/haproxy/cpuset.h
index d29c3560b..390115bcd 100644
--- a/include/haproxy/cpuset.h
+++ b/include/haproxy/cpuset.h
@@ -39,6 +39,6 @@ void ha_cpuset_assign(struct hap_cpuset *dst, const struct hap_cpuset *src);
/* Returns the biggest index plus one usable on the platform.
*/
-int ha_cpuset_size();
+int ha_cpuset_size(void);
#endif /* _HAPROXY_CPUSET_H */
--
2.33.0
>From c259a76dd9474a0a4e30982767144248ed350b84 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:50:04 +0200
Subject: [PATCH 03/42] CLEANUP: Fix prototype of ha_panic()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/debug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/debug.h b/include/haproxy/debug.h
index c6bdd7c5d..6d5eba6b8 100644
--- a/include/haproxy/debug.h
+++ b/include/haproxy/debug.h
@@ -31,6 +31,6 @@ void ha_thread_dump(struct buffer *buf, int thr, int calling_tid);
void ha_dump_backtrace(struct buffer *buf, const char *prefix, int dump);
void ha_backtrace_to_stderr(void);
void ha_thread_dump_all_to_trash();
-void ha_panic();
+void ha_panic(void);
#endif /* _HAPROXY_DEBUG_H */
--
2.33.0
>From cb39d1db9aa527c5ea57d084565abf7eff6da894 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 01:12:21 +0200
Subject: [PATCH 04/42] CLEANUP: Fix prototype of ha_random64()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/tools.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/tools.h b/include/haproxy/tools.h
index dec82e6b7..341a93e70 100644
--- a/include/haproxy/tools.h
+++ b/include/haproxy/tools.h
@@ -1027,7 +1027,7 @@ int parse_dotted_uints(const char *s, unsigned int **nums, size_t *sz);
void ha_generate_uuid(struct buffer *output);
void ha_random_seed(const unsigned char *seed, size_t len);
void ha_random_jump96(uint32_t dist);
-uint64_t ha_random64();
+uint64_t ha_random64(void);
static inline uint32_t ha_random32()
{
--
2.33.0
>From 11ee1f68b4ad932499e4347f5c6749ca833b936c Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:50:26 +0200
Subject: [PATCH 05/42] CLEANUP: Fix prototype of ha_thread_dump_all_to_trash()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/debug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/debug.h b/include/haproxy/debug.h
index 6d5eba6b8..7bfd12ed6 100644
--- a/include/haproxy/debug.h
+++ b/include/haproxy/debug.h
@@ -30,7 +30,7 @@ void ha_task_dump(struct buffer *buf, const struct task *task, const char *pfx);
void ha_thread_dump(struct buffer *buf, int thr, int calling_tid);
void ha_dump_backtrace(struct buffer *buf, const char *prefix, int dump);
void ha_backtrace_to_stderr(void);
-void ha_thread_dump_all_to_trash();
+void ha_thread_dump_all_to_trash(void);
void ha_panic(void);
#endif /* _HAPROXY_DEBUG_H */
--
2.33.0
>From 45c8edf332995fe7b13d097d4b1d1e739834e0c4 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 01:12:05 +0200
Subject: [PATCH 06/42] CLEANUP: Fix prototype of get_exec_path()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/tools.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/tools.h b/include/haproxy/tools.h
index 341a93e70..141b3dadb 100644
--- a/include/haproxy/tools.h
+++ b/include/haproxy/tools.h
@@ -981,7 +981,7 @@ void dump_addr_and_bytes(struct buffer *buf, const char *pfx, const void *addr,
void dump_hex(struct buffer *out, const char *pfx, const void *buf, int len, int unsafe);
int may_access(const void *ptr);
const void *resolve_sym_name(struct buffer *buf, const char *pfx, const void *addr);
-const char *get_exec_path();
+const char *get_exec_path(void);
void *get_sym_curr_addr(const char *name);
void *get_sym_next_addr(const char *name);
--
2.33.0
>From cf0b621cbbed0e231072dde5ee99233d8990cc44 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:32:57 +0200
Subject: [PATCH 07/42] CLEANUP: Fix prototype of check_config_validity()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/cfgparse.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/cfgparse.h b/include/haproxy/cfgparse.h
index 1c97a88b9..72a3720ff 100644
--- a/include/haproxy/cfgparse.h
+++ b/include/haproxy/cfgparse.h
@@ -101,7 +101,7 @@ int cfg_parse_track_sc_num(unsigned int *track_sc_num,
int readcfgfile(const char *file);
void cfg_register_keywords(struct cfg_kw_list *kwl);
void cfg_unregister_keywords(struct cfg_kw_list *kwl);
-int check_config_validity();
+int check_config_validity(void);
int str2listener(char *str, struct proxy *curproxy, struct bind_conf *bind_conf, const char *file, int line, char **err);
int str2receiver(char *str, struct proxy *curproxy, struct bind_conf *bind_conf, const char *file, int line, char **err);
int cfg_register_section(char *section_name,
--
2.33.0
>From 150087a9e1df3771e6358c95650ca53322a9e9b2 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:59:00 +0200
Subject: [PATCH 08/42] CLEANUP: Fix prototype of mworker_child_nb()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/mworker.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/mworker.h b/include/haproxy/mworker.h
index 279fb085d..986718b38 100644
--- a/include/haproxy/mworker.h
+++ b/include/haproxy/mworker.h
@@ -35,7 +35,7 @@ void mworker_accept_wrapper(int fd);
void mworker_cleanlisteners();
-int mworker_child_nb();
+int mworker_child_nb(void);
int mworker_ext_launch_all();
--
2.33.0
>From e88b8707375417ef09b34260dbaa47a8b5764bd8 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:35:12 +0200
Subject: [PATCH 09/42] CLEANUP: Fix prototype of
mworker_cli_proxy_(create|stop)()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/cli.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/haproxy/cli.h b/include/haproxy/cli.h
index 31020430e..6d66157d4 100644
--- a/include/haproxy/cli.h
+++ b/include/haproxy/cli.h
@@ -40,10 +40,10 @@ int cli_parse_default(char **args, char *payload, struct appctx *appctx, void *p
/* mworker proxy functions */
-int mworker_cli_proxy_create();
+int mworker_cli_proxy_create(void);
int mworker_cli_proxy_new_listener(char *line);
int mworker_cli_sockpair_new(struct mworker_proc *mworker_proc, int proc);
-void mworker_cli_proxy_stop();
+void mworker_cli_proxy_stop(void);
/* proxy mode cli functions */
--
2.33.0
>From fa5e353a3d95cb848532419442446317dd587d29 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:54:29 +0200
Subject: [PATCH 10/42] CLEANUP: Fix prototype of mworker_cleantasks()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/task.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/task.h b/include/haproxy/task.h
index f83aba784..45a4cf2c3 100644
--- a/include/haproxy/task.h
+++ b/include/haproxy/task.h
@@ -141,7 +141,7 @@ int next_timer_expiry();
/*
* Delete every tasks before running the master polling loop
*/
-void mworker_cleantasks();
+void mworker_cleantasks(void);
/* returns the number of running tasks+tasklets on the whole process. Note
* that this *is* racy since a task may move from the global to a local
--
2.33.0
>From e91cf1a52eec5e7666036f83dc08764b1d9146ec Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:04:54 +0200
Subject: [PATCH 11/42] CLEANUP: Fix prototype of mworker_cleanlisteners()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/mworker.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/mworker.h b/include/haproxy/mworker.h
index 986718b38..d3c1977e6 100644
--- a/include/haproxy/mworker.h
+++ b/include/haproxy/mworker.h
@@ -33,7 +33,7 @@ void mworker_catch_sigchld(struct sig_handler *sh);
void mworker_accept_wrapper(int fd);
-void mworker_cleanlisteners();
+void mworker_cleanlisteners(void);
int mworker_child_nb(void);
--
2.33.0
>From 0e54eeb19b7360db8e4d7af663d2007311ec143f Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:15:53 +0200
Subject: [PATCH 12/42] CLEANUP: Fix prototype of mworker_ext_launch_all()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/mworker.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/mworker.h b/include/haproxy/mworker.h
index d3c1977e6..dfcbf3926 100644
--- a/include/haproxy/mworker.h
+++ b/include/haproxy/mworker.h
@@ -37,7 +37,7 @@ void mworker_cleanlisteners(void);
int mworker_child_nb(void);
-int mworker_ext_launch_all();
+int mworker_ext_launch_all(void);
void mworker_kill_max_reloads(int sig);
--
2.33.0
>From 578b6420bd3d2823b8fe793618432c723b12528d Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:41:41 +0200
Subject: [PATCH 13/42] CLEANUP: Fix prototype of mworker_reload()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/global.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/global.h b/include/haproxy/global.h
index 460de1f11..043b4ccaa 100644
--- a/include/haproxy/global.h
+++ b/include/haproxy/global.h
@@ -65,7 +65,7 @@ int split_version(const char *version, unsigned int *value);
int compare_current_version(const char *version);
void mworker_accept_wrapper(int fd);
-void mworker_reload();
+void mworker_reload(void);
/* to be used with warned and WARN_* */
static inline int already_warned(unsigned int warning)
--
2.33.0
>From 96d34c75f42bd48e8c8622859e22b063edc81f30 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:59:39 +0200
Subject: [PATCH 14/42] CLEANUP: Fix prototype of
mworker_(env|proc_list)_to_(proc_list|env)()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/mworker.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/haproxy/mworker.h b/include/haproxy/mworker.h
index dfcbf3926..054536272 100644
--- a/include/haproxy/mworker.h
+++ b/include/haproxy/mworker.h
@@ -19,8 +19,8 @@
extern struct mworker_proc *proc_self;
-void mworker_proc_list_to_env();
-int mworker_env_to_proc_list();
+void mworker_proc_list_to_env(void);
+int mworker_env_to_proc_list(void);
void mworker_block_signals();
--
2.33.0
>From 05c7de9bed24b144f7e11955b74c74e071dc5636 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:00:23 +0200
Subject: [PATCH 15/42] CLEANUP: Fix prototype of mworker_(un|)block_signals()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/mworker.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/haproxy/mworker.h b/include/haproxy/mworker.h
index 054536272..0e166ac09 100644
--- a/include/haproxy/mworker.h
+++ b/include/haproxy/mworker.h
@@ -23,8 +23,8 @@ void mworker_proc_list_to_env(void);
int mworker_env_to_proc_list(void);
-void mworker_block_signals();
-void mworker_unblock_signals();
+void mworker_block_signals(void);
+void mworker_unblock_signals(void);
void mworker_broadcast_signal(struct sig_handler *sh);
void mworker_catch_sighup(struct sig_handler *sh);
--
2.33.0
>From 3c806fa106dcec2269d0ca2be22f69fd27e56a3f Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:41:10 +0200
Subject: [PATCH 16/42] CLEANUP: Fix prototype of proxy_adjust_all_maxconn()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/proxy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/proxy.h b/include/haproxy/proxy.h
index 8a2a5c85e..e16acde36 100644
--- a/include/haproxy/proxy.h
+++ b/include/haproxy/proxy.h
@@ -77,7 +77,7 @@ void proxy_capture_error(struct proxy *proxy, int is_back,
unsigned int buf_out, unsigned int err_pos,
const union error_snapshot_ctx *ctx,
void (*show)(struct buffer *, const struct error_snapshot *));
-void proxy_adjust_all_maxconn();
+void proxy_adjust_all_maxconn(void);
struct proxy *cli_find_frontend(struct appctx *appctx, const char *arg);
struct proxy *cli_find_frontend(struct appctx *appctx, const char *arg);
--
2.33.0
>From b665404545aff184aea766f28f38ca7933e10ce3 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:37:50 +0200
Subject: [PATCH 17/42] CLEANUP: Fix prototype of proxy_destroy_all_defaults()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/proxy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/proxy.h b/include/haproxy/proxy.h
index e16acde36..c7bc2c533 100644
--- a/include/haproxy/proxy.h
+++ b/include/haproxy/proxy.h
@@ -62,7 +62,7 @@ void init_new_proxy(struct proxy *p);
void proxy_preset_defaults(struct proxy *defproxy);
void proxy_free_defaults(struct proxy *defproxy);
void proxy_destroy_defaults(struct proxy *px);
-void proxy_destroy_all_defaults();
+void proxy_destroy_all_defaults(void);
struct proxy *alloc_new_proxy(const char *name, unsigned int cap,
char **errmsg);
struct proxy *parse_new_proxy(const char *name, unsigned int cap,
--
2.33.0
>From 0e54733188de9adbbb87da43ca19225b24d7f8bf Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:42:22 +0200
Subject: [PATCH 18/42] CLEANUP: Fix prototype of get_tainted()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/global.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/global.h b/include/haproxy/global.h
index 043b4ccaa..03c21d535 100644
--- a/include/haproxy/global.h
+++ b/include/haproxy/global.h
@@ -90,7 +90,7 @@ enum tainted_flags {
TAINTED_CLI_EXPERIMENTAL_MODE = 0x8,
};
void mark_tainted(const enum tainted_flags flag);
-unsigned int get_tainted();
+unsigned int get_tainted(void);
extern unsigned int experimental_directives_allowed;
--
2.33.0
>From 4998eb35ca6c3090beb1b5715c12f02776da88dc Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:42:56 +0200
Subject: [PATCH 19/42] CLEANUP: Fix prototype of pool_total_(allocated|used)()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/pool.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/haproxy/pool.h b/include/haproxy/pool.h
index 0bc683b1c..0e044db2e 100644
--- a/include/haproxy/pool.h
+++ b/include/haproxy/pool.h
@@ -55,8 +55,8 @@ void pool_free_nocache(struct pool_head *pool, void *ptr);
void dump_pools_to_trash();
void dump_pools(void);
int pool_total_failures();
-unsigned long pool_total_allocated();
-unsigned long pool_total_used();
+unsigned long pool_total_allocated(void);
+unsigned long pool_total_used(void);
void pool_flush(struct pool_head *pool);
void pool_gc(struct pool_head *pool_ctx);
struct pool_head *create_pool(char *name, unsigned int size, unsigned int flags);
--
2.33.0
>From 5b2918ae2eba960907fd09f048c746ffbfdda97f Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:48:14 +0200
Subject: [PATCH 20/42] CLEANUP: Fix prototype of thread_isolate(_full|)()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/thread.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/haproxy/thread.h b/include/haproxy/thread.h
index 51c727848..d9eeb9e40 100644
--- a/include/haproxy/thread.h
+++ b/include/haproxy/thread.h
@@ -167,8 +167,8 @@ static inline unsigned long thread_isolated()
#include <import/plock.h>
void thread_harmless_till_end();
-void thread_isolate();
-void thread_isolate_full();
+void thread_isolate(void);
+void thread_isolate_full(void);
void thread_release();
void thread_sync_release();
void ha_tkill(unsigned int thr, int sig);
--
2.33.0
>From 289b30a9f702c05bf4441db4dd375eff8c50a91f Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:48:48 +0200
Subject: [PATCH 21/42] CLEANUP: Fix prototype of thread(_sync|)_release()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/thread.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/haproxy/thread.h b/include/haproxy/thread.h
index d9eeb9e40..3121618b6 100644
--- a/include/haproxy/thread.h
+++ b/include/haproxy/thread.h
@@ -169,8 +169,8 @@ static inline unsigned long thread_isolated()
void thread_harmless_till_end();
void thread_isolate(void);
void thread_isolate_full(void);
-void thread_release();
-void thread_sync_release();
+void thread_release(void);
+void thread_sync_release(void);
void ha_tkill(unsigned int thr, int sig);
void ha_tkillall(int sig);
void ha_spin_init(HA_SPINLOCK_T *l);
--
2.33.0
>From ea97fcebf59aff83fc6fc91f6bcd6691d6b8a463 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:09:42 +0200
Subject: [PATCH 22/42] CLEANUP: Fix prototype of thread_harmless_till_end()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/thread.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/thread.h b/include/haproxy/thread.h
index 3121618b6..41e655df0 100644
--- a/include/haproxy/thread.h
+++ b/include/haproxy/thread.h
@@ -166,7 +166,7 @@ static inline unsigned long thread_isolated()
#include <string.h>
#include <import/plock.h>
-void thread_harmless_till_end();
+void thread_harmless_till_end(void);
void thread_isolate(void);
void thread_isolate_full(void);
void thread_release(void);
--
2.33.0
>From d3db302e4626e19ed471039f7c745d102311e296 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:10:06 +0200
Subject: [PATCH 23/42] CLEANUP: Fix prototype of thread_cpu_mask_forced()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/thread.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/thread.h b/include/haproxy/thread.h
index 41e655df0..f659653c3 100644
--- a/include/haproxy/thread.h
+++ b/include/haproxy/thread.h
@@ -325,7 +325,7 @@ static inline unsigned long thread_isolated()
/* Returns 1 if the cpu set is currently restricted for the process else 0.
* Currently only implemented for the Linux platform.
*/
-int thread_cpu_mask_forced();
+int thread_cpu_mask_forced(void);
#if !defined(DEBUG_THREAD) && !defined(DEBUG_FULL)
--
2.33.0
>From 407932a4dc635da72e0ea949bfbaa0bff476355d Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:51:01 +0200
Subject: [PATCH 24/42] CLEANUP: Fix prototype of dequeue_all_listeners()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/listener.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/listener.h b/include/haproxy/listener.h
index 3fb078f8c..1c37d34da 100644
--- a/include/haproxy/listener.h
+++ b/include/haproxy/listener.h
@@ -66,7 +66,7 @@ void stop_listener(struct listener *l, int lpx, int lpr, int lli);
void enable_listener(struct listener *listener);
/* Dequeues all listeners waiting for a resource the global wait queue */
-void dequeue_all_listeners();
+void dequeue_all_listeners(void);
/* Dequeues all listeners waiting for a resource in proxy <px>'s queue */
void dequeue_proxy_listeners(struct proxy *px);
--
2.33.0
>From 644c5c876e38271b1ebdce4300115a11fdd0da46 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:53:39 +0200
Subject: [PATCH 25/42] CLEANUP: Fix prototype of next_timer_expiry()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/task.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/task.h b/include/haproxy/task.h
index 45a4cf2c3..16e6559a4 100644
--- a/include/haproxy/task.h
+++ b/include/haproxy/task.h
@@ -136,7 +136,7 @@ void wake_expired_tasks();
* list and the global one. It may return TICK_ETERNITY if no timer is present.
* Note that the next timer might very well be slightly in the past.
*/
-int next_timer_expiry();
+int next_timer_expiry(void);
/*
* Delete every tasks before running the master polling loop
--
2.33.0
>From 6367c2ecf220295550195c502929a5d01f05562f Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:53:04 +0200
Subject: [PATCH 26/42] CLEANUP: Fix prototype of wake_expired_tasks()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/task.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/task.h b/include/haproxy/task.h
index 16e6559a4..b345df2e9 100644
--- a/include/haproxy/task.h
+++ b/include/haproxy/task.h
@@ -130,7 +130,7 @@ void process_runnable_tasks();
* Extract all expired timers from the timer queue, and wakes up all
* associated tasks.
*/
-void wake_expired_tasks();
+void wake_expired_tasks(void);
/* Checks the next timer for the current thread by looking into its own timer
* list and the global one. It may return TICK_ETERNITY if no timer is present.
--
2.33.0
>From 370670be8dc9c0acefc82b68f14004c83477fbcb Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:54:04 +0200
Subject: [PATCH 27/42] CLEANUP: Fix prototype of process_runnable_tasks()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/task.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/task.h b/include/haproxy/task.h
index b345df2e9..2fe5f74af 100644
--- a/include/haproxy/task.h
+++ b/include/haproxy/task.h
@@ -124,7 +124,7 @@ unsigned int run_tasks_from_lists(unsigned int budgets[]);
* - return the date of next event in <next> or eternity.
*/
-void process_runnable_tasks();
+void process_runnable_tasks(void);
/*
* Extract all expired timers from the timer queue, and wakes up all
--
2.33.0
>From 821e25bf4c6c81ee56460a069ce732406f656109 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:04:33 +0200
Subject: [PATCH 28/42] CLEANUP: Fix prototype of init_acl()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/acl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/acl.h b/include/haproxy/acl.h
index bd6e1db8b..ab96d1995 100644
--- a/include/haproxy/acl.h
+++ b/include/haproxy/acl.h
@@ -144,7 +144,7 @@ void acl_unregister_keywords(struct acl_kw_list *kwl);
/* initializes ACLs by resolving the sample fetch names they rely upon.
* Returns 0 on success, otherwise an error.
*/
-int init_acl();
+int init_acl(void);
void free_acl_cond(struct acl_cond *cond);
--
2.33.0
>From 307ca80d973dce6c0dd5b51e487d6dbf486d3134 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:18:27 +0200
Subject: [PATCH 29/42] CLEANUP: Fix prototype of init_buffer()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/dynbuf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/dynbuf.h b/include/haproxy/dynbuf.h
index d3377549e..c38b9c7e1 100644
--- a/include/haproxy/dynbuf.h
+++ b/include/haproxy/dynbuf.h
@@ -36,7 +36,7 @@
extern struct pool_head *pool_head_buffer;
-int init_buffer();
+int init_buffer(void);
void buffer_dump(FILE *o, struct buffer *b, int from, int to);
/*****************************************************************/
--
2.33.0
>From eaac94aa62bb98c6a3a41e279af38548347f2064 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:33:33 +0200
Subject: [PATCH 30/42] CLEANUP: Fix prototype of (de|)init_log_buffers()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/log.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/haproxy/log.h b/include/haproxy/log.h
index 4503be428..49fbe5bfd 100644
--- a/include/haproxy/log.h
+++ b/include/haproxy/log.h
@@ -57,8 +57,8 @@ extern int cum_log_messages;
void syslog_fd_handler(int fd);
/* Initialize/Deinitialize log buffers used for syslog messages */
-int init_log_buffers();
-void deinit_log_buffers();
+int init_log_buffers(void);
+void deinit_log_buffers(void);
/* build a log line for the session and an optional stream */
int sess_build_logline(struct session *sess, struct stream *s, char *dst, size_t maxsize, struct list *list_format);
--
2.33.0
>From 342f10d4f6e53f595509a3d0fdbd33b21b14e878 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:38:38 +0200
Subject: [PATCH 31/42] CLEANUP: Fix prototype of (de|)init_pollers()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/fd.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/haproxy/fd.h b/include/haproxy/fd.h
index 416025213..46faef4ff 100644
--- a/include/haproxy/fd.h
+++ b/include/haproxy/fd.h
@@ -82,12 +82,12 @@ void poller_pipe_io_handler(int fd);
* If none works, returns 0, otherwise 1.
* The pollers register themselves just before main() is called.
*/
-int init_pollers();
+int init_pollers(void);
/*
* Deinitialize the pollers.
*/
-void deinit_pollers();
+void deinit_pollers(void);
/*
* Some pollers may lose their connection after a fork(). It may be necessary
--
2.33.0
>From 446ad7c0be417c8eaab12caa23691a80b3288aea Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 12:38:57 +0200
Subject: [PATCH 32/42] CLEANUP: Fix prototype of fork_poller()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/fd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/fd.h b/include/haproxy/fd.h
index 46faef4ff..d07a03918 100644
--- a/include/haproxy/fd.h
+++ b/include/haproxy/fd.h
@@ -96,7 +96,7 @@ void deinit_pollers(void);
* the the current poller is destroyed and the caller is responsible for trying
* another one by calling init_pollers() again.
*/
-int fork_poller();
+int fork_poller(void);
/*
* Lists the known pollers on <out>.
--
2.33.0
>From 654387ba1a6a2fdcf1f98cf70acb6fddced83b67 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:05:42 +0200
Subject: [PATCH 33/42] CLEANUP: Fix prototype of pool_destroy_all()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/pool.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/pool.h b/include/haproxy/pool.h
index 0e044db2e..177ad9e47 100644
--- a/include/haproxy/pool.h
+++ b/include/haproxy/pool.h
@@ -62,7 +62,7 @@ void pool_gc(struct pool_head *pool_ctx);
struct pool_head *create_pool(char *name, unsigned int size, unsigned int flags);
void create_pool_callback(struct pool_head **ptr, char *name, unsigned int size);
void *pool_destroy(struct pool_head *pool);
-void pool_destroy_all();
+void pool_destroy_all(void);
int mem_should_fail(const struct pool_head *pool);
--
2.33.0
>From 3b7caf32f325cc44ec407ec2c337de454eca83f0 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:05:21 +0200
Subject: [PATCH 34/42] CLEANUP: Fix prototype of
pool_evict_from_local_caches()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/pool.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/pool.h b/include/haproxy/pool.h
index 177ad9e47..d4c5717a4 100644
--- a/include/haproxy/pool.h
+++ b/include/haproxy/pool.h
@@ -74,7 +74,7 @@ extern THREAD_LOCAL size_t pool_cache_bytes; /* total cache size */
extern THREAD_LOCAL size_t pool_cache_count; /* #cache objects */
void pool_evict_from_local_cache(struct pool_head *pool);
-void pool_evict_from_local_caches();
+void pool_evict_from_local_caches(void);
void pool_put_to_cache(struct pool_head *pool, void *ptr);
/* returns true if the pool is considered to have too many free objects */
--
2.33.0
>From 2f14d6bf5feecf8074d1d9b6df0969869b4273f5 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:06:42 +0200
Subject: [PATCH 35/42] CLEANUP: Fix prototype of pool_total_failures()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/pool.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/pool.h b/include/haproxy/pool.h
index d4c5717a4..f9d0ea910 100644
--- a/include/haproxy/pool.h
+++ b/include/haproxy/pool.h
@@ -54,7 +54,7 @@ void *pool_alloc_nocache(struct pool_head *pool);
void pool_free_nocache(struct pool_head *pool, void *ptr);
void dump_pools_to_trash();
void dump_pools(void);
-int pool_total_failures();
+int pool_total_failures(void);
unsigned long pool_total_allocated(void);
unsigned long pool_total_used(void);
void pool_flush(struct pool_head *pool);
--
2.33.0
>From 25cdbdf53d6c4a35d084bc77871091a463457d0e Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:06:14 +0200
Subject: [PATCH 36/42] CLEANUP: Fix prototype of dump_pools_to_trash()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/pool.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/pool.h b/include/haproxy/pool.h
index f9d0ea910..cb2c8b4de 100644
--- a/include/haproxy/pool.h
+++ b/include/haproxy/pool.h
@@ -52,7 +52,7 @@ void *pool_get_from_os(struct pool_head *pool);
void pool_put_to_os(struct pool_head *pool, void *ptr);
void *pool_alloc_nocache(struct pool_head *pool);
void pool_free_nocache(struct pool_head *pool, void *ptr);
-void dump_pools_to_trash();
+void dump_pools_to_trash(void);
void dump_pools(void);
int pool_total_failures(void);
unsigned long pool_total_allocated(void);
--
2.33.0
>From ca698659aeb0ff779cf58852c4b21150b505da2d Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:10:26 +0200
Subject: [PATCH 37/42] CLEANUP: Fix prototype of cfg_run_diagnostics()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/cfgdiag.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/cfgdiag.h b/include/haproxy/cfgdiag.h
index 6ec84b1e1..698910997 100644
--- a/include/haproxy/cfgdiag.h
+++ b/include/haproxy/cfgdiag.h
@@ -6,6 +6,6 @@
*
* Returns 0 if no diagnostic message has been found else 1.
*/
-int cfg_run_diagnostics();
+int cfg_run_diagnostics(void);
#endif /* _HAPROXY_CFGDIAG_H */
--
2.33.0
>From 224417dbd48ebeacbbe20e88b2f8bfc80ec50192 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:10:53 +0200
Subject: [PATCH 38/42] CLEANUP: Fix prototype of
tv_init_(process|thread)_date()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/time.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/haproxy/time.h b/include/haproxy/time.h
index c8358e00c..e9baab418 100644
--- a/include/haproxy/time.h
+++ b/include/haproxy/time.h
@@ -88,8 +88,8 @@ int tv_ms_cmp2(const struct timeval *tv1, const struct timeval *tv2);
* timeout).
*/
void tv_update_date(int max_wait, int interrupted);
-void tv_init_process_date();
-void tv_init_thread_date();
+void tv_init_process_date(void);
+void tv_init_thread_date(void);
char *timeofday_as_iso_us(int pad);
--
2.33.0
>From 59d7d80b2a0fcf46057185b9cf27391512929adc Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:14:41 +0200
Subject: [PATCH 39/42] CLEANUP: Fix prototype of __signal_process_queue()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/signal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/signal.h b/include/haproxy/signal.h
index 331b7fdc6..4998615bc 100644
--- a/include/haproxy/signal.h
+++ b/include/haproxy/signal.h
@@ -27,7 +27,7 @@ extern struct signal_descriptor signal_state[];
__decl_thread(extern HA_SPINLOCK_T signals_lock);
void signal_handler(int sig);
-void __signal_process_queue();
+void __signal_process_queue(void);
void deinit_signals();
struct sig_handler *signal_register_fct(int sig, void (*fct)(struct sig_handler *), int arg);
struct sig_handler *signal_register_task(int sig, struct task *task, int reason);
--
2.33.0
>From 26c798c888b70b6f6e0b23bb75262957531c3f1a Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:15:01 +0200
Subject: [PATCH 40/42] CLEANUP: Fix prototype of deinit_signals()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/signal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/signal.h b/include/haproxy/signal.h
index 4998615bc..5e3aae0a2 100644
--- a/include/haproxy/signal.h
+++ b/include/haproxy/signal.h
@@ -28,7 +28,7 @@ __decl_thread(extern HA_SPINLOCK_T signals_lock);
void signal_handler(int sig);
void __signal_process_queue(void);
-void deinit_signals();
+void deinit_signals(void);
struct sig_handler *signal_register_fct(int sig, void (*fct)(struct sig_handler *), int arg);
struct sig_handler *signal_register_task(int sig, struct task *task, int reason);
void signal_unregister_handler(struct sig_handler *handler);
--
2.33.0
>From bb5772d539d6cbd1d1115147cf3f021b98c66062 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:15:25 +0200
Subject: [PATCH 41/42] CLEANUP: Fix prototype of haproxy_unblock_signals()
To: [email protected]
Cc: [email protected]
Explicitly indicate the empty parameter list.
---
include/haproxy/signal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/haproxy/signal.h b/include/haproxy/signal.h
index 5e3aae0a2..25a4ef113 100644
--- a/include/haproxy/signal.h
+++ b/include/haproxy/signal.h
@@ -34,7 +34,7 @@ struct sig_handler *signal_register_task(int sig, struct task *task, int reason)
void signal_unregister_handler(struct sig_handler *handler);
void signal_unregister_target(int sig, void *target);
void signal_unregister(int sig);
-void haproxy_unblock_signals();
+void haproxy_unblock_signals(void);
static inline void signal_process_queue()
{
--
2.33.0
>From fbd37e8e801f432b73ab77b32f86e11f92aa814e Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Sun, 12 Sep 2021 13:21:54 +0200
Subject: [PATCH 42/42] CLEANUP: Remove prototype for non-existent
thread_get_default_count()
To: [email protected]
Cc: [email protected]
This is the only location of `thread_get_default_count` within the codebase.
---
include/haproxy/thread.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/haproxy/thread.h b/include/haproxy/thread.h
index f659653c3..0c4cc9a9a 100644
--- a/include/haproxy/thread.h
+++ b/include/haproxy/thread.h
@@ -46,7 +46,6 @@
/* Generic exports */
int parse_nbthread(const char *arg, char **err);
-int thread_get_default_count();
extern int thread_cpus_enabled_at_boot;
--
2.33.0
