Hi David, On Tue, Jan 25, 2022 at 10:40:57AM +0000, David CARLIER wrote: > From 575cdb49b8fa923bdd44fe08a7068681e38ffe71 Mon Sep 17 00:00:00 2001 > From: David Carlier <[email protected]> > Date: Tue, 25 Jan 2022 10:37:59 +0000 > Subject: [PATCH] BUILD/MINOR: debug haiku build fix. > > O_ASYNC fcntl flag equivalent on this platform is O_RSYNC. > --- > src/debug.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/debug.c b/src/debug.c > index c15c92650..bd6353846 100644 > --- a/src/debug.c > +++ b/src/debug.c > @@ -25,6 +25,9 @@ > #ifdef USE_EPOLL > #include <sys/epoll.h> > #endif > +#ifdef __HAIKU__ > +#define O_ASYNC O_RSYNC > +#endif
Hmmm I see, we didn't use O_ASYNC previously. However I'm surprised with the use of this flag, usually O_ASYNC tends to be remapped to O_NONBLOCK (that we already use everywhere else). As such I would have done a possibly more portable: #ifndef O_ASYNC #define O_ASYNC O_NONBLOCK #endif I could/should do even better in fact, which consists in conditioning such flags to their definition as is already done for a few of them. Willy
