On Sat, Nov 19, 2022 at 06:25:39PM +0500, Илья Шипицин wrote: > Hello, > can we settle it before 2.7 ? > пн, 7 нояб. 2022 г. в 11:50, Willy Tarreau <[email protected]>: > > On Wed, Nov 02, 2022 at 10:43:49AM +0100, William Lallemand wrote: > > > > > - if (!tp->choosen) > > > > > + if (!tp->chosen) > > > > > return; > > > > > > > > > > - chunk_appendf(b, "\n\tversion_information:(choosen=0x%08x", > > tp->choosen); > > > > > + chunk_appendf(b, "\n\tversion_information:(chosen=0x%08x", > > tp->coosen); > > > > > > > > > I don't think it will even compile this way. > > > > I confirm it doesn't. I was about to fix it myself but I'd firt like > > to get a confirmation that it's OK to change this. > > > > Willy > >
Hello, I'm testing the patch, there was issues with renaming done wrong : coosen instead of chosen : - chunk_appendf(b, "\n\tversion_information:(choosen=0x%08x", tp->choosen); + chunk_appendf(b, "\n\tversion_information:(chosen=0x%08x", tp->coosen); chooen instead of chosen : -/* Encode version information transport parameters with <choosen_version> as choosen +/* Encode version information transport parameters with <chooen_version> as chosen With this adjusted it compiled. I'm definitely ok with spelling patch but you should at least try to compile it before submitting because it's pretty easy to miss errors on this kind of fix. Anyway thanks for your help. -- Amaury Denoyelle
