Le 16/09/2023 à 06:19, Vladimir Vdovin a écrit :
Added set-timeout for frontend side of session, so it can be used to set dynamically per-client timeouts if needed.
Thanks ! It looks good. However I have few comments. First it could be good to add a sample fetch to retrieve the current timeout, just like other custom timeouts. To be consistant, it could be good to add "cur_client_timeout" sample fetch in stream.c. It could be done in a separate commit if that makes your life easier.
Then, about the parsing, there is an issue. With your change, timeouts can only be customized for proxies with the frontend and the backend capabilities. It could be good to test the timeout type to restrict the action to a specific kind of proxy. By calling cfg_parse_rule_set_timeout() first, you can then test the proxy capabilities in conjunction with the timeout type.
Finally, could you update "reg-tests/http-set-timeout/set_timeout.vtc" script to add a test about the client timeout.
Of course, if you need some help or if you have any question, ask for it. -- Christopher Faulet
