On Mon, Oct 23, 2023 at 01:07:37PM +0000, Tristan wrote: > Hi Willy, > > On 23/10/2023 10:16, Willy Tarreau wrote: > > No more comments, overall this looks good to me. Thus in summary, let's > > try to avoid the ambiguity of "tune.lua.log" alone, and re-adjust the > > bitfields. By the way, if we're having the same prefix "tune.lua.log" > > for both options, it's an indication that we should likely have a dot > > after to enable loggers (or any other name) and stderr: > > > > tune.lua.log.loggers on|off > > tune.lua.log.stderr on|auto|off > > > > One being prefix of the other was also not great. So even if "log.loggers" > is a little awkward, this is probably for the best after all.
Yeah I share the same feeling, not being proud of that name either :-) > So here's the 2 patches again. Hopefully they match what you wanted. > > Two notes: > - I saw various forms of enum declarations in the codebase (naming it or not > and typedef-ing or not) and I don't practice C enough to have an opinion on > the matter, so I just picked the one I think looks nicest... > - For the regtests, if we don't want them to tee stderr to check it, then > there's little point, and chance of breaking this all is also rather low > anyway as you said, so none added Overall it looks good to me as is. I'll let Aurélien have a quick look as well in case he sees anything but I'm personally fine with merging this. Thank you! Willy
