the reason of adding ngtcp2 is

"let's add and see how it goes".

and that is what we agreed in GH issue :)

сб, 24 авг. 2024 г. в 18:45, Willy Tarreau <[email protected]>:

> On Sat, Aug 24, 2024 at 06:15:59PM +0200, ???? ??????? wrote:
> > it is pretty much about it.
> > short commit message "CI: QUIC Interop AWS-LC: enable ngtcp2 client"
> > describes what is done, GH issue is optional.
>
> But it does not explain why (or what the purpose is). As I often say
> it, commit messages must explain the intent, much more than the what.
> I know it's less important for CI which is a bit of a side project,
> but regardless, I'm wondering things like "what's the impact, will
> this regularly break some tests or take more time to build?" then
> "but if so, what's the purpose first?".
>
> I'm perfectly fine with simple explanations like "we have no other
> QUIC client and we need one", or "it's the simplest QUIC client we've
> found for now", or "ngtcp2's client provides stats others do not", or
> "let's start with this one for now, we may change it later" etc.
> See ?
>
> Thanks!
> Willy
>

Reply via email to