Hello William, This is in continuation of the earlier patches submitted to add 4 new sample fetches to extract cipher, supported groups, key shares and signature algorithms from client hello message. In the previous patches we added the 4 new sample fetches and a test for it.
In this patch we add a new helper function `smp_client_hello_parse` to extract information presented in a TLS client hello handshake message that is common in the other sample fetches in payload.c. We have modified these 7 sample fetches to use this new helper function. David Kelsey here at IBM also contributed to this last patch and helped me fix all the formatting issues, so hopefully that will make it easy for you to review. Thank you David. Thank you William for helping us move this forward. Appreciate all your feedback. Regards, Mariam. Mariam John (1): MINOR: ssl: Introduce new smp_client_hello_parse() function src/payload.c | 645 ++++++++++++++------------------------------------ 1 file changed, 174 insertions(+), 471 deletions(-) -- 2.39.3 (Apple Git-145)
