On 2009-12-15 23:35, Willy Tarreau wrote:
Hi Krzysztof,
On Tue, Dec 15, 2009 at 10:48:23PM +0100, Krzysztof Piotr Oledzki wrote:
>From b05e4be21fc2a1f56fc43cedc0229dd45fb54158 Mon Sep 17 00:00:00 2001
From: Krzysztof Piotr Oledzki <[email protected]>
Date: Tue, 15 Dec 2009 22:45:54 +0100
Subject: [BUG] config: fix erroneous check on cookie domain names, again
The previous check was correct: the RFC states that it is required
to have a domain-name which contained a dot AND began with a dot.
However, currently some (all?) browsers do not obey this specification,
so such configuration might work.
This patch reverts 3d8fbb6658d4414dac20892bbd9e79e14e99e67f but
changes the check from FATAL to WARNING and extends the warning.
I agree with this proposed behaviour (and failed to apply it in time).
I also think that I will add a warning for the multiple domains usage
because not all browsers support it either. However, your patch below
does not reflect what it says above. I believe you diffed between some
wrong commit IDs.
Ouch, yes. Sorry. I'll resend it.
