Hi Cyril, On Tue, Jan 26, 2010 at 10:25:06PM +0100, Cyril Bonté wrote: > Hi Willy, > > Le Lundi 25 Janvier 2010 02:29:24, Willy Tarreau a écrit : > > (...) > > - the stickiness code was merged. > > Sorry today I don't have time to work on a patch, but I hope the feedback > will help you. > I've made a very quick test with this feature and I met 2 errors : > 1. the code won't compile with DEBUG_FULL due to a typo in the DPRINTF > parameters in the function process_store_rules() [src/session.c] (req instead > of rep).
Ah thanks for catching this one. > 2. the configuration parser fails on "sticky-table". > I took the example provided in the documentation : > stick-table type ip size 200k expire 30m > > which results in > parsing [../haproxy.cfg:16] : stick-table: missing size. > > This is due to a conflict in cfgparse.c and the function > stktable_parse_type() [src/stick_table.c] which both increment the args index > : at the end of the loop in cfgparse.c, the index points to "200k" instead of > "size". I got hit by this one too this afternoon and have fixed it, it will be in tomorrow's snapshot. It works if you set the type as the last argument on the line. Thanks ! Willy
