On Sun, Jan 31, 2010 at 10:34:03PM +0100, Cyril Bonté wrote:
> OK, I didn't see it like this. I thought it was better to have the same
> behaviour as if those servers were not checked at all, and that users have
> the possibility to disable the tracking servers by hand.
In fact not because the sole purpose of server tracking is to reflect
a similar state without multiplying checks.
> I've modified the patch to follow your recommandations : tracking servers are
> now DOWN when the tracked server is in maintenance (which makes the code a
> little simpler).
That's nice, thanks. The patch is clean and I didn't spot any
error. I could test it and it's working fine in various tests
I have performed. So I've applied it. However I have made a
minor change : on my display, the MAINT and DOWN colors were
very close to each others and the italics were almost unreadable
on small fonts. So after searching for a while, I have changed
the bgcolor to a light brown which is easily distinguished from
down servers : ".maintain {background: #c07820;}"
I'm hesitating whether we should report the tracking servers the
same color, because it's not an error if they appear down, it's
an expected condition which should not necessarily attrack the
eye. I don't know what you (or others) think about that.
Best regards,
Willy
