Hi, On Thu, Dec 09, 2010 at 01:37:15PM +0100, Andreas Kohn wrote: > Hi, > > while trying to implement a feature to dynamically add/remove servers > from a backend (patches for that in another mail soon) I found an odd > line in assign_server(): > > s->prev_srv = s->prev_srv; > > Shouldn't this be > > s->prev_srv = s->srv? > > Or, am I missing something here?
You're obviously right. In fact it has never caused any issue because it's already done right in srv_redispatch_connect(). That said, it's better to fix it. I think the best fix would consist in removing the line to avoid any confusion. Regards, Willy
