Re: [PATCH] "include" configuration directive for haproxy 1.5-dev3

[L. Alberto Giménez]

On 14/12/2010 20:30, Brane F. Gračnar wrote:
Hello :)

Hi Brane,

I haven't had time to test your patch, but after a "visual" review made 
some doubts to come up.

And, please, post your patches inline, they are easier to review :)

@@ -5343,6 +5440,40 @@ int readcfgfile(const char *file)
                        err_code |= ERR_ALERT | ERR_FATAL;
                }

[...]
+                       memset(file_dir, '\0', buf_len);
+                       strcpy(file_dir, file);
+                       strcpy(file_dir, dirname(file_dir));

The first strcpy would be useless here?

@@ -5193,6 +5195,99 @@ out:
        return err_code;
 }
[...]
+       /** we want to support relative to include file glob patterns */
+       int buf_len = 3;
+       if (dir != NULL)
+               buf_len += strlen(dir);

Could you please clarify where does that "magic" 3 coming from?. As I 
said, I couldn't test the patch, and I can't figure it out for myself.

Thanks a lot!

--
L. Alberto Giménez