Hi Krzysztof, nice to see you back here with fingers itching to write some code :-)
On Wed, Oct 17, 2012 at 08:11:03AM +0200, Krzysztof Ol??dzki wrote: > >Could be an idea too. Anyway I think that people who would use the CSS > >URL would already have a server ready for this. This basically makes > >sense for intern monitoring teams where web servers are deployed > >everywhere. > > Well, yes, but if the server is down, css will not be loaded and this > will make it harder to read the stats page and to find, that the server > is down. Possibly, it will also require a lot of time to load the page. Possible. I was suggesting this because I've already seen some places where some logos were fetched this way, so I'm sure that it's not a big issue for everybody! > BTW: if you are going to implement reading a css from a file, please > make sure that we check if size of the file is <= BUFSIZE minus html > headers. Very good point. > Probably the easiest way to do this, is to split DATA_ST_HEAD into > DATA_ST_HEAD_BEGIN, DATA_ST_HEAD_CSS and DATA_ST_HEAD_END, so we can > fill msg up to the trashlen in DATA_ST_HEAD_CSS. I think this is what I > did, when I was implementing this. Good idea. Then we can even decide to send more if we store the restart offset. > And yes, I still should have a ~2y old patch patch somewhere for this, > but have not been able to find this while writing this e-mail. I wish I > had sent it then. :| Anyway, I will try to find it tomorrow - it is 11PM > here, time to sleep. ;) Ah, this problem of lost patches plagues all of us! If you can find it, I'm sure it will be welcome. Cheers, Willy
