Hi Willy,
I've just finished patching haproxy-1.5-dev14 to use my unique-id header code,
which we discussed a year or so ago. There's one thing I'm not 100% sure
about. You changed the interface of http_find_header2(). Previously, the
third argument was an int, now it's a char*. I'm assuming that where I used to
do:
+ if (! http_find_header2(hdr, hdr_len, msg->sol, &txn->hdr_idx,
&ctx)) {
I now want
+ if (! http_find_header2(hdr, hdr_len, msg->chn->buf->p +
msg->sol, &txn->hdr_idx, &ctx)) {
yes? This is in proto_http.c, http_wait_for_request().
Have you given any more thought to picking up this patch for the official
version? We've been running it in production for well over a year with no
problems. Yesterdays' traffic volume was 73 million HTTP requests, so I think
we've given it a fair workout. The feature has proven invaluable for debugging
problems in the site, as it lets us easily correlate lines in our haproxy,
nginx, and application log files. I'm sure many other haproxy users would find
it equally useful.
---
Roy Smith
[email protected]
