Hello Dmitry, On Mon, Dec 24, 2012 at 11:31:47PM +0400, Dmitry Sivachenko wrote: > Hello! > > After update from -dev15, the following stats listener: > > listen stats9 :30009 > mode http > stats enable > stats uri / > stats show-node > stats show-legends > > returns 503/Service unavailable.
Oh dear! I'm really angry because this is a beginner's bug and because I did all the tests for this last commit using the config I've been using for the stats page, except that I did not request the stats page during the tests. Pfff... Here's the fix, it will show up in snapshot 20121226 tomorrow. Thanks for reporting this, Dmitry. Willy
>From 418c1a0a9563f90a665c6434f39d2576af48cdc1 Mon Sep 17 00:00:00 2001 From: Willy Tarreau <[email protected]> Date: Tue, 25 Dec 2012 20:52:58 +0100 Subject: [PATCH] BUG/MEDIUM: stats: fix stats page regression introduced by commit 20b0de5 This commit adding http-request add-header/set-header unfortunately introduced a regression to the handling of the stats page which is not matched anymore. Thanks to Dmitry Sivachenko for reporting this. --- src/proto_http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/proto_http.c b/src/proto_http.c index c715828..deed52e 100644 --- a/src/proto_http.c +++ b/src/proto_http.c @@ -3113,11 +3113,11 @@ http_check_access_rule(struct proxy *px, struct list *rules, struct session *s, trash.str[trash.len++] = ' '; trash.len += build_logline(s, trash.str + trash.len, trash.size - trash.len, &rule->arg.hdr_add.fmt); http_header_add_tail2(&txn->req, &txn->hdr_idx, trash.str, trash.len); - break; + return rule; } } } - return rule; + return NULL; } /* This stream analyser runs all HTTP request processing which is common to -- 1.7.12.4.dirty
