Hi there,

On Wed, 08 May 2013, 18:19:43 +0200, Clayton Keller wrote:
> [...]
> Had a "." slip in there on the "BuildRoot" value, my apologies.
> Here's what should have been sent:

>From my experience with building RPMs, this is very close to what should
be applied. The rest is nit-picking, such as defining 1.5 as the
full_version, and adding further minor versions attached to it. But the
version you have sent should just work!

Cheers.

l8er
manfred

> # diff -u haproxy.spec.orig haproxy.spec
> --- haproxy.spec.orig   2013-05-06 10:19:48.462440897 -0500
> +++ haproxy.spec        2013-05-06 22:33:24.175855675 -0500
> @@ -1,11 +1,15 @@
> +%define full_version 1.5-dev18
> +%define version %(echo %{full_version} | awk -F "-" '{print $1}')
> +%define release %(echo %{full_version} | awk -F "-" '{print $2}')
> +
>  Summary: HA-Proxy is a TCP/HTTP reverse proxy for high availability
> environments
>  Name: haproxy
> -Version: 1.5-dev18
> -Release: 1
> +Version: %{version}
> +Release: %{release}
>  License: GPL
>  Group: System Environment/Daemons
>  URL: http://haproxy.1wt.eu/
> -Source0:
> http://haproxy.1wt.eu/download/1.5/src/devel/%{name}-%{version}.tar.gz
> +Source0: 
> http://haproxy.1wt.eu/download/1.5/src/devel/%{name}-%{version}-%{release}.tar.gz
>  BuildRoot: %{_tmppath}/%{name}-%{version}-root
>  BuildRequires: pcre-devel
>  Requires: /sbin/chkconfig, /sbin/service
> @@ -27,7 +31,7 @@
>  risking the system's stability.
> 
>  %prep
> -%setup -q
> +%setup -q -n %{name}-%{version}-%{release}
> 
>  # We don't want any perl dependecies in this RPM:
>  %define __perl_requires /bin/true

Reply via email to