On 2013-7-21 21:17, Willy Tarreau wrote:
No, I really mean UWGHT_MAX set to UWGHT_RANGE since it is used to
fix set highest user weight that can be set.

Willy



Yeah, I get what you meant now. With the following fix:

diff --git a/include/types/server.h b/include/types/server.h
index b58a062..062b06e 100644
--- a/include/types/server.h
+++ b/include/types/server.h
@@ -72,7 +72,7 @@

 /* various constants */
 #define SRV_UWGHT_RANGE 256
-#define SRV_UWGHT_MAX   (SRV_UWGHT_RANGE - 1)
+#define SRV_UWGHT_MAX   SRV_UWGHT_RANGE
 #define SRV_EWGHT_RANGE (SRV_UWGHT_RANGE * BE_WEIGHT_SCALE)
 #define SRV_EWGHT_MAX   (SRV_UWGHT_MAX   * BE_WEIGHT_SCALE)

Roundrobin can work well with server's weight 256 after testing again.

So I should post two patches, one for source code and the other one for documentation. There are also related comments of roundrobin and/or leastconn to be fixed together.

I will finish this job carefully and post patches ASAP.

--
Best Regards,
Godbach


Reply via email to