Hi Apollon, On Mon, Aug 12, 2013 at 01:07:57PM +0300, Apollon Oikonomopoulos wrote: > Hi Willy, > > We are seeing build failures of 1.5 w/ SSL on Debian's Hurd builder machines > due to the use of PATH_MAX (which is undefined in Hurd) when loading SSL > certificates. You can see the build log here: > > https://buildd.debian.org/status/fetch.php?pkg=haproxy&arch=hurd-i386&ver=1.5%7Edev19-1&stamp=1372199388 > > The attached patch should fix this issue, by modifying the code in > question to use a dynamically allocated buffer while checking against > PATH_MAX if appropriate.
Unfortunately, this patch introduces a memory leak. Since the path variable is just a temporary one, better use alloca() instead in order to dynamically allocate on the stack. Anyway I'd prefer something simpler : let's define PATH_MAX in compat.h if it is not defined. Thanks, Willy
