On Mon, Nov 25, 2013 at 12:43:59PM +0100, Willy Tarreau wrote: > On Mon, Nov 25, 2013 at 10:06:16AM +0000, Malcolm Turnbull wrote: > > Willy, > > > > Our agent currently replies with: > > > > drain\n > > stop\n > > 50%\n > > etc. > > > > and its not in production yet (looking forward to it being merged), so > > no problem to change if you prefer a different method. > > Instead better not to change the agent, it's already OK. We just need > to reflect that in the code :-) > > I don't remember the exact protocol spec, if it explicitly mentionned > the \n. But we definitely should before it's too late !
Thanks for merging my patches :-) I'll take a look at tightening up both the code and documentation to enforce a trailing'\n'. As things stand, I believe it does handle messages with a trailing '\n' as my testing was done using echo "whatever" | wc -l -p something -q=0. I think that if the code looked for a '\n' then the -q=0 would not be necessary.
