Hi folks,
> On Sat, 23 Nov 2013 12:05:24 +0100 > Willy Tarreau <[email protected]> wrote: > >> Hi Mark-Antoine, >> >> On Sat, Nov 23, 2013 at 07:37:21PM +0900, Marc-Antoine Perennou wrote: >>> I don't have access to a computer to actually test those, but: >>> - the first one looks nice, never felt really confident hard coding >>> SBINDIR and the solution makes sense >>> - nice catch for the second one, didn't think of the sigint when >>> writing it, lgtm >>> - third one is trivial enough not to harm anyone >>> >>> +1 for me >> >> OK that's perfect, I'm merging them. >> >> Thanks for your fast response! >> Willy >> >> > > Sounds great, thank you both! > Let me know if there are any issues. There is a compiler warning after commit 1b6e75fa84 ("MEDIUM: haproxy- systemd-wrapper: Use haproxy in same directory"): src/haproxy-systemd-wrapper.c: In function ‘locate_haproxy’: src/haproxy-systemd-wrapper.c:28:10: warning: ignoring return value of ‘readlink’, declared with attribute warn_unused_result [-Wunused-result] Can we silence the warning as per the diff attached? If you agree, I will send a proper patch to Willy. Thanks, Lukas
silence-readlink.diff
Description: Binary data
