Re: Crash on removing response header

[Willy Tarreau]

On Wed, Jan 01, 2014 at 12:58:11PM +0000, William Lewis wrote:
> Hi Willy,
> 
> Your previous email didn't contain a patch to disable regexec().

Hehe usual problem on my side. First forgotten attachment of the year :-)
Here it is now.

> I can confirm that the crash still consistently occurs with the minimal 
> config you suggested.

OK great, thanks.

Willy


diff --git a/src/proto_http.c b/src/proto_http.c
index 7a9eaa0..c91d8c8 100644
--- a/src/proto_http.c
+++ b/src/proto_http.c
@@ -7158,7 +7165,7 @@ int apply_filter_to_resp_headers(struct session *t, 
struct channel *rtr, struct
                term = *cur_end;
                *cur_end = '\0';
 
-               if (regexec(exp->preg, cur_ptr, MAX_MATCH, pmatch, 0) == 0) {
+               if (1 || regexec(exp->preg, cur_ptr, MAX_MATCH, pmatch, 0) == 
0) {
                        switch (exp->action) {
                        case ACT_ALLOW:
                                txn->flags |= TX_SVALLOW;