Hi, On Fri, Apr 18, 2014 at 12:05:25AM +0900, Marc-Antoine Perennou wrote: > Hi, > > On Thursday, April 17, 2014, Apollon Oikonomopoulos <[email protected]> > wrote: > > > Hi, > > > > The following patches improve the systemd wrapper in a couple of ways: > > > > - The systemd wrapper itself is now re-executed on SIGUSR2, allowing a new > > version of both HAProxy and the wrapper to be gracefully loaded. > > - We use standard error for message logging, which seems to get more > > reliably > > to systemd's journal than stdout. > > - We also use systemd's support for prefixing messages with the log level > > to > > differentiate between message severity. > > - Finally, we propagate the exit status of HAProxy to systemd, instead of > > always returning success. > > > > Regards, > > Apollon > > > > Apollon Oikonomopoulos (3): > > MINOR: systemd wrapper: re-execute on SIGUSR2 > > MINOR: systemd wrapper: improve logging > > MINOR: systemd wrapper: propagate exit status > > > > src/haproxy-systemd-wrapper.c | 69 > > ++++++++++++++++++++++++++++++------------- > > 1 file changed, 49 insertions(+), 20 deletions(-) > > > > -- > > 1.9.1 > > > > > > > > Looks good to me. > Any comments, Will?
You're the systemd wrapper author and maintainer so I don't have to have any comment and I fully trust your opinion on this. Thus I just merged these 3 patches :-) Thanks guys! Willy
