Hey, On 07/25/2014 08:31 AM, Willy Tarreau wrote: >> There was only one small bug really, but once I got going I thought i >> might as well simplify it a litle. I pulled everything out of the signal >> handlers, switched from signal() to sigaction(), got rid of global state >> and got rid of the wrapper exec()'ing itself (not sure if there was some >> reason for that, but it seems to be unneccessary). > > From what I remember, the purpose was to be able to upgrade the wrapper > itself without having to kill it. Typically in order to apply changes > like you just performed... So I think you should bring that feature back.
Oh, right, I actually knew that before. Another proof of the importance of sometimes taking a step back. Also, I'll add a comment :) > You cleanup patch is interesting but it does too many things at once for > a single patch, I'd strongly prefer if you would cut it into pieces each > addressing a specific issue. It would make the code more easily reviewable > and would also help troubleshooting in the event it would cause any minor > regression. Sounds very reasonable. I'll see if I can break it in chunks that would be independently revertable, although I think that may be difficult, but at least things will be easier to review and merge. Will get back soon! Conrad -- Conrad Hoffmann Traffic Engineer SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany Managing Director: Alexander Ljung | Incorporated in England & Wales with Company No. 6343600 | Local Branch Office | AG Charlottenburg | HRB 110657B
