Hi Dave,
On Mon, Sep 08, 2014 at 04:25:22PM -0400, Dave McCowan wrote:
> >
> >
> > Second patch :
> >
> > > diff --git a/include/types/connection.h b/include/types/connection.h
> > > index 89f4f38..a75d45d 100644
> > > --- a/include/types/connection.h
> > > +++ b/include/types/connection.h
> > > @@ -334,6 +334,7 @@ struct proxy_hdr_v2 {
> > > #define PP2_TYPE_SSL 0x20
> > > #define PP2_TYPE_SSL_VERSION 0x21
> > > #define PP2_TYPE_SSL_CN 0x22
> > > +#define PP2_TYPE_NETWORK_NAMESPACE 0x30
> >
> > Could you please avoid to fragment the values here, I fear the day we need
> > a contiguous array and we can't find one anymore. Let's start at 0x23 for
> > now. Note, since we're in development, we can change these numbers later,
> > so let's not consider the PPv2 spec as "official" whenever it comes to what
> > we stuff in haproxy-dev.
> >
>
> Can I reserve three spots for SSL_SNI, SSL_NPN, and SSL_ALPN? We can try
> to keep the SSL block contiguous for now.
CCing Amos who's implementing ALPN support in Squid and who needs an ID as well.
Dave, since you're the one who started to assign numbers here, I'd like that
you centralize these numbers for now and at least that they're enumerated in
the doc.
Also, it's unclear to me why they start at 0x20 and not 0x00 for example. Since
code has already been shipping with these values, we won't change them, however
it's important to avoid fragmenting the space too much.
> Willy--
> I will provide a patch for those three. Would you prefer a 1.5 base or
> a 1.6 base?
Always provide patches for the development tree. That ensures that the patch
we merge into stable versions is a real backport and includes the mainline
commit ID.
Thanks,
Willy
