On Tue, Oct 07, 2014 at 07:28:55AM -0500, Andrew Latham wrote:
> Willy
>
> Diff attached. Happy to help if there are any issues.
Andrew, if I asked for the format-patch output, it's because it
provides your commit message, your authorship etc...
You just have to do this :
git format-patch -1 $COMMIT
with the commit ID in $COMMIT, or simply "git format-patch -1" if
the commit is the last one.
Then it gives you a file named 0001-your-subject.patch that you
can simply send and that I'll apply using "git am". It's also
very convenient for reviewers since they can make comments inline
about some specific parts of code.
Also, keep in mind that having a patch ready for merging is the
best way to ensure it will get quickly accepted. On the opposite,
expecting any upstream maintainer to write the commit message
themselves for something they did not write is the best way to
ensure the patch will stay there forever.
Last, please take a look at section 5 of the README ("how to
contribute"), it explains how to write a relevant subject that I
will not have to edit when merging it. That's equally a key to
having your patches quickly merged.
Do not hesitate to ask for any help, it's very important for me
that contributors feel at ease with submitting changes. Don't be
afraid of doing mistakes, we all do.
Thanks,
Willy
