Hi all,

Le 22/10/2014 10:30, Willy Tarreau a écrit :
I wonder if the flags shouldn't be cleaned up more than it is in
http_end_txn_clean_session(), but I'm not sure and didn't have time to
check this yesterday.
Something like :
   s->flags &= ~(SN_ERR_MASK | SN_FINST_MASK);

Absolutely, it ought to be done, I'm even surprized we don't have it!
It's possible that it accidently disappeared some time ago. It's also
possible that it has never been there because previously, we did not
support keep-alive on stats, so all non-empty termination codes caused
the connection to be closed, and we never noticed it. If you have some
time to prepare a patch doing this and to test it, I'll happily merge
it. Otherwise I can do it, so it's as you like.

I've just sent the patch.

After reviewing the code, a third flag was missing, which lead to report redispatched requests when it was not the case.
All other flags have been checked, and they look OK ;-)

--
Cyril Bonté

Reply via email to