Dear Willy, This is great news. We'd like to thank you for your help and valuable input and suggestions.
On Fri, Nov 21, 2014 at 8:00 AM, Willy Tarreau <[email protected]> wrote: > Hi Krisztian, > > On Thu, Nov 20, 2014 at 08:39:24PM +0100, KOVACS Krisztian wrote: > > Dear Willy & list, > > > > Here's the next round of the patch(es), this time with the following > major > > changes: > > > > * I've merged your fixes and updated the docs with the new namespace_list > > semantics > > * default namespace initialization was moved to a function called from > > init(): this way we can signal errors and do default namespace init only > if > > it's required (ie. the config uses namespaces) I did not find a way to do > > this properly from a constructor function. > > > > I've also attached a fix for missing sanitization of the header length: > the > > code did not check that hdr_v2->len is large enough to contain the > address > > family specific address information. > > Great. The patch looks good now, it builds fine with and without NS > support. > I have merged it so that it gets broader review. > > I think we'll change a few things in the near future, such as probably > rename > "namespace_list" to "namespaces" to be more consistent with "peers" vs > "peer" > for example. I also think we don't need that create_server_socket() > function, > and we'd rather open-code it in the caller so that we don't use 2 layers of > obfuscation on top of socket() here. As you see, these are very tiny > details, > what matters the most is that it's now merged and we can all start to play > with it. > > So, many thanks for this work! > Willy > > -- KOVACS Krisztian
